fix: make bulkSave() continue to use validateSync() for backwards compat

Author: vkarpov15

lib/model.js

@@ -3571,7 +3571,7 @@ Model.bulkSave = async function bulkSave(documents, options) {
 
   await Promise.all(documents.map(doc => buildPreSavePromise(doc, options)));
 
-  const writeOperations = await this.buildBulkWriteOperations(documents, options);
+  const writeOperations = this.buildBulkWriteOperations(documents, options);
   const opts = { skipValidation: true, _skipCastBulkWrite: true, ...options };
   const { bulkWriteResult, bulkWriteError } = await this.bulkWrite(writeOperations, opts).then(
     (res) => ({ bulkWriteResult: res, bulkWriteError: null }),
@@ -3866,20 +3866,23 @@ Model.castObject = function castObject(obj, options) {
  * @api private
  */
 
-Model.buildBulkWriteOperations = async function buildBulkWriteOperations(documents, options) {
+Model.buildBulkWriteOperations = function buildBulkWriteOperations(documents, options) {
   if (!Array.isArray(documents)) {
     throw new Error(`bulkSave expects an array of documents to be passed, received \`${documents}\` instead`);
   }
 
   setDefaultOptions();
 
-  const writeOperations = await Promise.all(documents.map(async(document, i) => {
+  const writeOperations = documents.map((document, i) => {
     if (!options.skipValidation) {
       if (!(document instanceof Document)) {
         throw new Error(`documents.${i} was not a mongoose document, documents must be an array of mongoose documents (instanceof mongoose.Document).`);
       }
       if (options.validateBeforeSave == null || options.validateBeforeSave) {
-        await document.validate();
+        const err = document.validateSync();
+        if (err != null) {
+          throw err;
+        }
       }
     }
 
@@ -3917,7 +3920,7 @@ Model.buildBulkWriteOperations = async function buildBulkWriteOperations(documen
     }
 
     return null;
-  })).then(results => results.filter(op => op !== null));
+  }).filter(op => op !== null);
 
   return writeOperations;
 

test/model.test.js

@@ -6780,7 +6780,7 @@ describe('Model', function() {
       await users[2].save();
       users[2].name = 'I am the updated third name';
 
-      const writeOperations = await User.buildBulkWriteOperations(users);
+      const writeOperations = User.buildBulkWriteOperations(users);
 
       const desiredWriteOperations = [
         { insertOne: { document: users[0] } },
@@ -6795,7 +6795,7 @@ describe('Model', function() {
 
     });
 
-    it('throws an error when one document is invalid', async() => {
+    it('throws an error when one document is invalid', () => {
       const userSchema = new Schema({
         name: { type: String, minLength: 5 }
       });
@@ -6808,14 +6808,10 @@ describe('Model', function() {
         new User({ name: 'b' })
       ];
 
-      let err;
-      try {
-        await User.buildBulkWriteOperations(users);
-      } catch (error) {
-        err = error;
-      }
-
-      assert.ok(err);
+      assert.throws(
+        () => User.buildBulkWriteOperations(users),
+        /name: Path `name` \(`a`\) is shorter than the minimum allowed length/
+      );
     });
 
     it('throws an error if documents is not an array', function() {
@@ -6826,8 +6822,8 @@ describe('Model', function() {
       const User = db.model('User', userSchema);
 
 
-      assert.rejects(
-        User.buildBulkWriteOperations(null),
+      assert.throws(
+        () => User.buildBulkWriteOperations(null),
         /bulkSave expects an array of documents to be passed/
       );
     });
@@ -6838,16 +6834,15 @@ describe('Model', function() {
 
       const User = db.model('User', userSchema);
 
-
-      assert.rejects(
-        User.buildBulkWriteOperations([
+      assert.throws(
+        () => User.buildBulkWriteOperations([
           new User({ name: 'Hafez' }),
           { name: 'I am not a document' }
         ]),
         /documents\.1 was not a mongoose document/
       );
     });
-    it('skips validation when given `skipValidation` true', async() => {
+    it('skips validation when given `skipValidation` true', () => {
       const userSchema = new Schema({
         name: { type: String, minLength: 5 }
       });
@@ -6860,7 +6855,7 @@ describe('Model', function() {
         new User({ name: 'b' })
       ];
 
-      const writeOperations = await User.buildBulkWriteOperations(users, { skipValidation: true });
+      const writeOperations = User.buildBulkWriteOperations(users, { skipValidation: true });
 
       assert.equal(writeOperations.length, 3);
     });