refactor: remove unnecessary variable re: code review comments

vkarpov15 · vkarpov15 · commit b91db2b66bd3 · 2025-05-05T15:29:42.000-04:00
diff --git a/lib/helpers/schema/getPath.js b/lib/helpers/schema/getPath.js
@@ -26,14 +26,13 @@ module.exports = function getPath(schema, path, discriminatorValueMap) {
     schematype = schema.path(cur);
     if (schematype != null && schematype.schema) {
       schema = schematype.schema;
-      const currentPath = cur;
-      cur = '';
       if (!isArray && schematype.$isMongooseDocumentArray) {
         isArray = true;
       }
-      if (discriminatorValueMap && discriminatorValueMap[currentPath]) {
-        schema = schema.discriminators[discriminatorValueMap[currentPath]] ?? schema;
+      if (discriminatorValueMap && discriminatorValueMap[cur]) {
+        schema = schema.discriminators[discriminatorValueMap[cur]] ?? schema;
       }
+      cur = '';
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -26,14 +26,13 @@ module.exports = function getPath(schema, path, discriminatorValueMap) {`
`26`	`26`	`schematype = schema.path(cur);`
`27`	`27`	`if (schematype != null && schematype.schema) {`
`28`	`28`	`schema = schematype.schema;`
`29`		`- const currentPath = cur;`
`30`		`- cur = '';`
`31`	`29`	`if (!isArray && schematype.$isMongooseDocumentArray) {`
`32`	`30`	`isArray = true;`
`33`	`31`	`}`
`34`		`- if (discriminatorValueMap && discriminatorValueMap[currentPath]) {`
`35`		`- schema = schema.discriminators[discriminatorValueMap[currentPath]] ?? schema;`
	`32`	`+ if (discriminatorValueMap && discriminatorValueMap[cur]) {`
	`33`	`+ schema = schema.discriminators[discriminatorValueMap[cur]] ?? schema;`
`36`	`34`	`}`
	`35`	`+ cur = '';`
`37`	`36`	`}`
`38`	`37`	`}`
`39`	`38`