refactor: address code review comments by moving regexp to constant

vkarpov15 · vkarpov15 · commit 5d7ec67b755e · 2023-10-09T16:07:36.000-04:00
diff --git a/lib/schema.js b/lib/schema.js
@@ -37,6 +37,8 @@ const isPOJO = utils.isPOJO;
 
 let id = 0;
 
+const numberRE = /^\d+$/;
+
 /**
  * Schema constructor.
  *
@@ -2638,7 +2640,7 @@ Schema.prototype._getSchema = function(path) {
       // Re: gh-5628, because `schema.path()` doesn't take $ into account.
       parts[i] = '0';
     }
-    if (/^\d+$/.test(parts[i])) {
+    if (numberRE.test(parts[i])) {
       parts[i] = '$';
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ const isPOJO = utils.isPOJO;`
`37`	`37`
`38`	`38`	`let id = 0;`
`39`	`39`
	`40`	`+const numberRE = /^\d+$/;`
	`41`	`+`
`40`	`42`	`/**`
`41`	`43`	`* Schema constructor.`
`42`	`44`	`*`
`@@ -2638,7 +2640,7 @@ Schema.prototype._getSchema = function(path) {`
`2638`	`2640`	// Re: gh-5628, because `schema.path()` doesn't take $ into account.
`2639`	`2641`	`parts[i] = '0';`
`2640`	`2642`	`}`
`2641`		`- if (/^\d+$/.test(parts[i])) {`
	`2643`	`+ if (numberRE.test(parts[i])) {`
`2642`	`2644`	`parts[i] = '$';`
`2643`	`2645`	`}`
`2644`	`2646`	`}`