Skip to content

Commit 1667acb

Browse files
authored
Merge pull request #14076 from ffflorian/fix/remove-count
fix: Remove count() from TypeScript definitions
2 parents 1b725cf + bc8af5f commit 1667acb

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

types/middlewares.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ declare module 'mongoose' {
55
type MongooseDistinctDocumentMiddleware = 'save' | 'init' | 'validate';
66
type MongooseDocumentMiddleware = MongooseDistinctDocumentMiddleware | MongooseQueryAndDocumentMiddleware;
77

8-
type MongooseDistinctQueryMiddleware = 'count' | 'estimatedDocumentCount' | 'countDocuments' | 'deleteMany' | 'distinct' | 'find' | 'findOne' | 'findOneAndDelete' | 'findOneAndReplace' | 'findOneAndUpdate' | 'replaceOne' | 'updateMany';
8+
type MongooseDistinctQueryMiddleware = 'estimatedDocumentCount' | 'countDocuments' | 'deleteMany' | 'distinct' | 'find' | 'findOne' | 'findOneAndDelete' | 'findOneAndReplace' | 'findOneAndUpdate' | 'replaceOne' | 'updateMany';
99
type MongooseDefaultQueryMiddleware = MongooseDistinctQueryMiddleware | 'updateOne' | 'deleteOne';
1010
type MongooseQueryMiddleware = MongooseDistinctQueryMiddleware | MongooseQueryAndDocumentMiddleware;
1111

types/models.d.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -201,15 +201,6 @@ declare module 'mongoose' {
201201
/** Collection the model uses. */
202202
collection: Collection;
203203

204-
/** Creates a `count` query: counts the number of documents that match `filter`. */
205-
count(filter?: FilterQuery<TRawDocType>): QueryWithHelpers<
206-
number,
207-
THydratedDocumentType,
208-
TQueryHelpers,
209-
TRawDocType,
210-
'count'
211-
>;
212-
213204
/** Creates a `countDocuments` query: counts the number of documents that match `filter`. */
214205
countDocuments(
215206
filter?: FilterQuery<TRawDocType>,

types/query.d.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -259,15 +259,6 @@ declare module 'mongoose' {
259259
/** Specifies the `comment` option. */
260260
comment(val: string): this;
261261

262-
/** Specifies this query as a `count` query. */
263-
count(criteria?: FilterQuery<DocType>): QueryWithHelpers<
264-
number,
265-
DocType,
266-
THelpers,
267-
RawDocType,
268-
'count'
269-
>;
270-
271262
/** Specifies this query as a `countDocuments` query. */
272263
countDocuments(
273264
criteria?: FilterQuery<DocType>,

0 commit comments

Comments
 (0)