Skip to content

Bug: incorrect use_unverified_ssl variable usage #20

@figroc

Description

@figroc

Description

https://github.com/Authing/authing-py-sdk/blob/0e0e0aa82e500f5667aa8b26e1a00e11720b7c2b/authing/http/ManagementHttpClient.py#L12C62-L12C62

https://github.com/Authing/authing-py-sdk/blob/0e0e0aa82e500f5667aa8b26e1a00e11720b7c2b/authing/http/ManagementHttpClient.py#L35C14-L35C14

Minimal code-snippet showcasing the problem

        self.use_unverified_ssl = use_unverified_ssl or FALSE
        ...
        verify = not self.use_unverified_ssl
        r = requests.request(..., verify=verify, ...)

not FALSE is False

Expected behavior

respect the https verification requirement

Actual behavior

/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py:1099: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.authing.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions