Custom icons sizes don't apply to custom folder associations

[theMikeD]

Describe the bug
When creating custom folder associations ( Appearance & Behaviour --> Atom Material Icons --> Associations, Folder Associations), any custom ones created are not resized when the icon size is adjusted (Appearance & Behaviour --> Atom Material Icons --> Settings, Icons Settings, Size and Line Height).

To Reproduce

1. Go to Appearance & Behaviour --> Atom Material Icons --> Associations, Folder Associations
2. Create a new custom folder icon. I have attached the one I used, which is based on a-file-icon-idea/common/src/main/resources/icons/nodes/folder.svg
3. Go to Appearance & Behaviour --> Atom Material Icons --> Settings, Icons Settings, Size and Line Height and change the icons size to something obvious, and apply

Expected Behaviour

1. The custom folder icon will be resized to match the other icons, and will match the custom size set. This is not happening.

Environment

PhpStorm 2024.3
Build #PS-243.21565.202, built on November 13, 2024
Licensed to Mike D
Subscription is active until November 4, 2025.
Runtime version: 21.0.5+8-b631.16 x86_64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.lwawt.macosx.LWCToolkit
macOS 14.7.1
GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation
Memory: 4096M
Cores: 16
Metal Rendering is ON
Registry:
  debugger.watches.in.variables=false
  run.processes.with.pty=TRUE
  ide.experimental.ui=true
  i18n.locale=
Non-Bundled Plugins:
  com.nasller.CodeGlancePro (1.9.5)
  com.jetbrains.space (243.21565.122)
  com.godwin.json.parser (1.8.1)
  com.intellij.react.css.modules (1.0.1)
  ru.adelf.idea.dotenv (2024.3)
  com.mallowigi (97.0.0)
  mobi.hsz.idea.gitignore (4.5.4)

[theMikeD]

Updated the IDE and the problem remains. Atom Material Icons v101.2.0 is installed, but is not listed in the below info for whatever reason.

PhpStorm 2024.3.2.1
Build #PS-243.23654.168, built on January 24, 2025
Licensed to Mike D
Subscription is active until November 4, 2025.
Runtime version: 21.0.5+8-b631.30 x86_64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.lwawt.macosx.LWCToolkit
macOS 14.7.1
GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation
Memory: 4096M
Cores: 16
Metal Rendering is ON
Registry:
  debugger.watches.in.variables=false
  run.processes.with.pty=TRUE
  ide.experimental.ui=true
Non-Bundled Plugins:
  com.nasller.CodeGlancePro (1.9.6)
  com.jetbrains.space (243.23654.19)
  com.godwin.json.parser (1.8.2)
  com.intellij.properties (243.22562.9)
  com.intellij.react.css.modules (1.0.1)
  ru.adelf.idea.dotenv (2024.3)
  com.mallowigi (101.2.0)
  mobi.hsz.idea.gitignore (4.5.6)

[mallowigi]

Try to add a width and height parameter to your custom icons

[theMikeD]

Are we debugging this or is that something you know works? In either case, it didn't work. Attached is updated icon; this was added width="16" height="16"

Maybe you could point me to the folder icon used there so I could compare?

[mallowigi]

The code stipulates:

private fun patchSizes(attributes: MutableMap<String, String>) {
    val hasWidth = attributes[SvgPatcher.WIDTH]
    val customFontSize = AtomSettingsConfig.instance.customIconSize.toString()
    val hasCustomSize = AtomSettingsConfig.instance.hasCustomIconSize
    val size = if (hasCustomSize) customFontSize else DEFAULT_ICON_SIZE

    if (hasWidth == "16" || hasWidth == "16px") {
      attributes[SvgPatcher.WIDTH] = size.toString() + SvgPatcher.PX
      attributes[SvgPatcher.HEIGHT] = size.toString() + SvgPatcher.PX
    }
  }

[theMikeD]

Not sure I follow. You suggested I add a width and a height, which I did: 16px for each. I don't read the language of the code you posted but by the look of it, if the size in the file is 16px, it'll use 16 and ignore the custom font size?

What is the solution then? Changing the size to something other than 16px makes no difference (I changed it to 24px, and now the icons in the interface are 24px).

Again, please: if you can be specific about the fix, that would be really helpful, and I'll test it right away.

Thanks.

[mallowigi]

This piece of code states that when parsing files it should replace the width by the custom size.

Historically this feature wasn't working for custom icons but I thought that the new implementation that parsed widths would not have this problem, guess I was wrong.

I'll investigate.