MiniflareCoreError: Unable to resolve dynamic module specifiers

[carlreid]

After updating all packages to their latest versions, an error occurred when running vite dev. You can see the demo project located at GitHub Repository. I've also made a Workflow that just installs packages, and attempts to npm run dev which produces the same error output can be seen at this GitHub Actions run.

The specific error message is as follows:

MiniflareCoreError [ERR_MODULE_DYNAMIC_SPEC]: Unable to resolve "<script:0>" dependency: dynamic module specifiers are unsupported.
You must manually define your modules when constructing Miniflare:
  new Miniflare({
    modules: [
      { type: "ESModule", path: "<script:0>" }
    ]
  })

To reproduce the issue, you can use the provided demo project at the above GitHub repository.

I did change to index.ts (TypeScript) but even switching that back to plain .js it seems to cause the same problem with the import from what I can tell.

[Aslemammad]

Thank you so much, I'll be putting some time on this. if you want to put time, let me know, a bit busy here.

[carlreid]

Sure, I'll update here if I try anything 👍 I've been a bit busy myself to even play with the toy project of mine that makes use of this.

[Aslemammad]

Sure, feel free to.

[Aslemammad]

Hey I explored this issue. The problem is with @brillout's vite-plugin-import-build and import packages because the worker file has an import that esbuild couldn't process.

// node_modules/.pnpm/@brillout+import@0.2.3/node_modules/@brillout/import/dist/index.js
var require_dist = __commonJS({
  "node_modules/.pnpm/@brillout+import@0.2.3/node_modules/@brillout/import/dist/index.js"(exports6) {
    init_process();
    Object.defineProperty(exports6, "__esModule", { value: true });
    exports6.import_ = void 0;
    exports6.default = import_;
    function import_(id) {
      id = fixWindowsBug(id);
      return import(
        /*webpackIgnore: true*/
        id
      );
    }
    exports6.import_ = import_;
    var prefix = "file://";
    function fixWindowsBug(id) {
      if (process.platform === "win32" && isAbsolute(id) && !id.startsWith(prefix)) {
        return prefix + id;
      } else {
        return id;
      }
    }
    function isAbsolute(path) {
      return /^[/\\](?![/\\])|^[/\\]{2}(?!\.)|^[A-Za-z]:[/\\]/.test(path);
    }
  }
});

And the MiniflareCoreError points exactly to the function import_(id) {
section. I tried importing vite-plugin-ssr, vite-plugin-ssr/server and ../dist/server/importBuild.cjs in the worker file. All have the same issue.

I'd like to see a way where these trick-imports are not imported and used in the worker file.

[brillout]

Since a lot of folks are successfully using esbuild to bundle VPS and its dist/server/, I'm inclined to think it's more related to how you configure esbuild.

[Aslemammad]

@brillout Yes, that may be the reason, because the error happens in new versions of vps (post import build packages). Do you have any minimal example that's working so I can check it out. I'd appreciate that. Thanks.

[brillout]

https://github.com/brillout/build-worker

…

On Tue, Jul 25, 2023 at 9:58 AM Mohammad Bagher Abiat < ***@***.***> wrote: @brillout <https://github.com/brillout> Yes, that may be the reason, because the error happens in new versions of vps (post import build packages). Do you have any minimal example that's working so I can check it out. I'd appreciate that. Thanks. — Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHVQRUKFBTMLZDUII22HVLXR54CJANCNFSM6AAAAAAZ3OTGWI> . You are receiving this because you were mentioned.Message ID: ***@***.***>