Skip to content

No report comment, given a previous base-coverage-file is provided. #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
craigdallimore opened this issue Feb 17, 2025 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@craigdallimore
Copy link

craigdallimore commented Feb 17, 2025

Describe a bug

Given I've provided a path to a current report, the coverage comment is created (good!)
Given I've provided paths to previous and current reports, no coverage comment is created (bad, silent failure)

Expected behavior

Expected a coverage comment to be added to the PR, showing the coveragedelta between the current report and the previous report

Details

  • Action version: 2

  • ubuntu-latest

  • action.yml file
      - name: Coverage
        uses: ArtiomTr/jest-coverage-report-action@v2
        with:
          working-directory: ${{github.workspace}}/my-subfolder
          coverage-file: report.json
          base-coverage-file: ${{ steps.coverage-file.outputs.path }}
          skip-step: all
          annotations: none
  • Logs
    
        Run ArtiomTr/jest-coverage-report-action@v2
          with:
            working-directory: /home/runner/work/[elided]
            coverage-file: report.json
            base-coverage-file: ./previous-coverage/report.json
            skip-step: all
            annotations: none
            github-token: ***
            test-script: npx jest
            icons: emoji
            package-manager: npm
            output: comment
        Run $GITHUB_ACTION_PATH/run.sh
          $GITHUB_ACTION_PATH/run.sh
          shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
          env:
            INPUT_GITHUB-TOKEN: ***
            INPUT_TEST-SCRIPT: npx jest
            INPUT_THRESHOLD: 
            INPUT_WORKING-DIRECTORY: /home/runner/work/[elided]
            INPUT_ICONS: emoji
            INPUT_ANNOTATIONS: none
            INPUT_PACKAGE-MANAGER: npm
            INPUT_SKIP-STEP: all
            INPUT_CUSTOM-TITLE: 
            INPUT_COVERAGE-FILE: report.json
            INPUT_BASE-COVERAGE-FILE: ./previous-coverage/report.json
            INPUT_PRNUMBER: 
            INPUT_OUTPUT: comment
        Running using node v[2](https://github.com/[elided]/runs/13362699678/job/37314972420#step:8:2)2.13.1
        Begin initialization stage...
        Initialization stage ended
        Begin stages.parsethreshold...
        stages.parseThreshold ended
        Begin stages.getbranch...
        /usr/bin/git show -s --pretty=%D HEAD
        grafted, HEAD, pull/292[4](https://github.com/GetThematic/thematic-results-client-portal/actions/runs/13362699678/job/37314972420#step:8:4)/merge
        stages.getBranch ended
        Begin stages.switchtohead...
        stages.switchToHead skipped
        stages.switchToHead ended
        Begin head coverage collection...
        Begin installing dependencies...
        Installing dependencies skipped
        Installing dependencies ended
        Begin running tests...
        Running tests skipped
        Running tests ended
        Begin collecting coverage...
        Loading code coverage from file: /home/runner/work/[elided]/report.json
        Collecting coverage ended
        Begin parsing coverage...
        Parsing coverage ended
        Head coverage collection ended
        Begin switching to base branch...
        Switching to base branch skipped
        Switching to base branch ended
        Begin base coverage collection...
        Begin installing dependencies...
        Installing dependencies skipped
        Installing dependencies ended
        Begin running tests...
        Running tests skipped
        Running tests ended
        Begin collecting coverage...
        Loading code coverage from file: /home/runner/work/[elided]/previous-coverage/report.json
        Collecting coverage ended
        Begin parsing coverage...
        Parsing coverage ended
        Base coverage collection ended
        Begin switching back to original branch...
        /usr/bin/git fetch --all --depth=1
        [elided]
        /usr/bin/git checkout -f pull/2924/merge
        HEAD is now at e156f6d Merge ca3e33f4c9b57769c67f38c326f4db2ff3b880c4 into f358b1d6b25cbe81da7c590a5a740111cc4c03ab
        Switching back to original branch ended
        Begin stages.checkthreshold...
        stages.checkThreshold ended
        Begin generating run report...
        Generating run report ended
        Begin failed tests' annotations publication...
        Failed tests' annotations publication skipped
        Failed tests' annotations publication ended
        Begin coverage annotations publication...
        Coverage annotations publication skipped
        Coverage annotations publication ended
        Begin generating report...
        Generating report ended
        Begin report publish...
        Report publish ended
        Begin setting outputs...
        Setting outputs skipped
        Setting outputs ended
    

Additional context

The previous report matches the format of the current report and is brought into the filesystem so the action can compare both.
I've verified that both reports are present and well formed (the action will error if they are not correct in these ways).
The action does not need to switch branches as both files are present; I'm not sure why it is trying to switch branches.
The main thing is: if I provide a previous-coverage/report.json, no comment gets made on the PR. There is no error message explaining the absence.
If I make base-coverage-file and coverage-file point to the same file, I do get the expected comment (but no delta).

I'm not sure what I need to change.

@craigdallimore craigdallimore added the bug Something isn't working label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants