Question: Menu of Input?

[TheBjoel2]

I need to have an undefined number of input bars in my interface. It also would be nice if there was a scroll ability for that. There is a similar thing when you make a Menu:

std::vector<std::string> nameToComeUpWith;
nameToComeUpWith.push_back("123");
nameToComeUpWith.push_back("456");
nameToComeUpWith.push_back("789");

int a;
auto thing = Menu(&nameToComeUpWith, &a);

It has almost everything, even a scroll ability, except input ability.
Unfortunately, the following does not work:

std::vector<Component> componentVector;
std::vector<std::string> stringVector;
stringVector.resize(undefined);
for(int i = 0; i < undefined; i++)
        componentVector.push_back(Input(&stringVector[i], "text"));
int a;
auto thing = Menu(&componentVector, &a);

How can I achieve it?

[ArthurSonzogni]

On this example:

#include "ftxui/component/screen_interactive.hpp"  // for Component, ScreenInteractive
#include "ftxui/dom/elements.hpp"
#include "ftxui/component/component.hpp"

int main(int argc, const char* argv[]) {
  using namespace ftxui;

  Component input_list = Container::Vertical({});
  std::vector<std::string> items(100, "");
  for (int i = 0; i < items.size(); ++i) {
    input_list->Add(Input(&(items[i]), "placeholder " + std::to_string(i)));
  }

  auto renderer = Renderer(input_list, [&] {
    return input_list->Render() | vscroll_indicator | frame | border |
           size(HEIGHT, LESS_THAN, 10);
  });

  auto screen = ScreenInteractive::TerminalOutput();
  screen.Loop(renderer);
}

and by patching FTXUI using:

diff --git a/src/ftxui/component/input.cpp b/src/ftxui/component/input.cpp
index c78bf60..c6afe8e 100644
--- a/src/ftxui/component/input.cpp
+++ b/src/ftxui/component/input.cpp
@@ -156,10 +156,9 @@ class WideInputBase : public ComponentBase {
     if (!box_.Contain(event.mouse().x, event.mouse().y))
       return false;
 
-    TakeFocus();
-
     if (event.mouse().button == Mouse::Left &&
         event.mouse().motion == Mouse::Pressed) {
+      TakeFocus();
       int new_cursor_position =
           cursor_position() + event.mouse().x - cursor_box_.x_min;
       new_cursor_position =
@@ -168,8 +167,9 @@ class WideInputBase : public ComponentBase {
         cursor_position() = new_cursor_position;
         option_->on_change();
       }
+      return true;
     }
-    return true;
+    return false;
   }
 
   bool Focusable() const final { return true; }

test-2021-11-02_00.07.45.mp4

I can get this behavior:I need to take a closer look during this week and update FTXUI accordingly. Thanks for opening this!

[ArthurSonzogni]

And fixed:
#253