From 2a86a0d8740f923b891ef54c926ba0a178511f25 Mon Sep 17 00:00:00 2001 From: eslamwael74 Date: Sat, 7 Dec 2024 19:58:44 +0200 Subject: [PATCH 1/3] - change the generated resources path to com.pdftron.pdf.tools --- .../java/com/pdftron/pdftronflutter/helpers/PluginUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/pdftron/pdftronflutter/helpers/PluginUtils.java b/android/src/main/java/com/pdftron/pdftronflutter/helpers/PluginUtils.java index 9ed4c8c7..60266bdf 100644 --- a/android/src/main/java/com/pdftron/pdftronflutter/helpers/PluginUtils.java +++ b/android/src/main/java/com/pdftron/pdftronflutter/helpers/PluginUtils.java @@ -59,7 +59,7 @@ import com.pdftron.pdf.widget.toolbar.builder.AnnotationToolbarBuilder; import com.pdftron.pdf.widget.toolbar.builder.ToolbarButtonType; import com.pdftron.pdf.widget.toolbar.component.DefaultToolbars; -import com.pdftron.pdftronflutter.R; +import com.pdftron.pdf.tools.R; import com.pdftron.pdf.PDFDraw; import org.apache.commons.io.FileUtils; From 2cb6259c302e8871ba02a05f7768552bbe795aae Mon Sep 17 00:00:00 2001 From: eslamwael74 Date: Sat, 7 Dec 2024 19:59:50 +0200 Subject: [PATCH 2/3] - add compileSdk - add namespace - update compileSdk to v34 --- android/build.gradle | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index 213bc720..be83671d 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -25,7 +25,9 @@ rootProject.allprojects { apply plugin: 'com.android.library' android { - compileSdkVersion 33 + namespace 'com.pdftron.pdftronflutter' + + compileSdk 34 defaultConfig { minSdkVersion 19 From 099462a0a9b5230b431410428c8c1191be358545 Mon Sep 17 00:00:00 2001 From: Eslam wael Date: Sat, 22 Feb 2025 18:24:22 +0200 Subject: [PATCH 3/3] - removes unused Plugin registration using Android embedding v1 removes unused not found path `io.flutter.plugin.common.PluginRegistry.Registrar` and related code that is thrown a build error --- .../pdftronflutter/PdftronFlutterPlugin.java | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/android/src/main/java/com/pdftron/pdftronflutter/PdftronFlutterPlugin.java b/android/src/main/java/com/pdftron/pdftronflutter/PdftronFlutterPlugin.java index aeffc32a..24b78ca0 100644 --- a/android/src/main/java/com/pdftron/pdftronflutter/PdftronFlutterPlugin.java +++ b/android/src/main/java/com/pdftron/pdftronflutter/PdftronFlutterPlugin.java @@ -1,7 +1,5 @@ package com.pdftron.pdftronflutter; -import android.content.Context; - import com.pdftron.pdftronflutter.factories.DocumentViewFactory; import com.pdftron.pdftronflutter.helpers.PluginMethodCallHandler; @@ -10,7 +8,6 @@ import io.flutter.embedding.engine.plugins.activity.ActivityPluginBinding; import io.flutter.plugin.common.BinaryMessenger; import io.flutter.plugin.common.MethodChannel; -import io.flutter.plugin.common.PluginRegistry.Registrar; import io.flutter.plugin.platform.PlatformViewRegistry; /** @@ -56,16 +53,4 @@ public void onReattachedToActivityForConfigChanges(ActivityPluginBinding binding @Override public void onDetachedFromActivity() { } - - /** - * Plugin registration using Android embedding v1. - */ - public static void registerWith(Registrar registrar) { - final MethodChannel methodChannel = new MethodChannel(registrar.messenger(), "pdftron_flutter"); - methodChannel.setMethodCallHandler(new PluginMethodCallHandler(registrar.messenger(), registrar.activeContext())); - registrar - .platformViewRegistry() - .registerViewFactory(viewTypeId, - new DocumentViewFactory(registrar.messenger(), registrar.activeContext())); - } }