Fix crashlytics (#158)

* Ignore all modification in the french readme in the CI

* Enable crashlytics for Android

* Enable crashlytics for iOS.

* When an error is logged report it to crashlytics

* Change badge url

* Remove unused import.

* Add stacktrace to the crashlytics report.

Author: apomalyn

.github/workflows/main-workflow.yaml

@@ -8,6 +8,7 @@ on:
       - '.metadata'
       - '.github/**'
       - 'README.md'
+      - 'README.fr.md'
   pull_request:
 env:
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -91,6 +92,7 @@ jobs:
           export COV="$(./scripts/determine_code_coverage.sh coverage/lcov.info)"
           echo "Coverage detected is: $COV"
           echo "::set-output name=percentage::$COV"
+
   coverage:
     name: Update coverage
     needs: [ testing ]
@@ -114,7 +116,7 @@ jobs:
         uses: schneegans/dynamic-badges-action@v1.1.0
         with:
           auth: ${{ secrets.GIST_COVERAGE_BADGE_TOKEN }}
-          gistID: 63e992d7042dbac4db9abaecb78df0eb
+          gistID: ${{ secrets.GIST_ID_COVERAGE_BADGE }}
           filename: notre_dame_master_badge_coverage.json
           label: Code coverage
           message: ${{ needs.testing.outputs.coverage }}

README.fr.md

@@ -5,9 +5,9 @@
     <br />
     <br />
     <a href="https://github.com/ApplETS/Notre-Dame/actions/workflows/main-workflow.yaml" style="text-decoration: none;">
-      <img src="https://github.com/ApplETS/Notre-Dame/actions/workflows/main-workflow.yaml/badge.svg?event=push&branch=master" alt="Statut de la compilation"/>
-      <img src="https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/apomalyn/63e992d7042dbac4db9abaecb78df0eb/raw/notre_dame_master_badge_coverage.json" alt="Code coverage"/>
+      <img src="https://github.com/ApplETS/Notre-Dame/actions/workflows/main-workflow.yaml/badge.svg?branch=master" alt="Statut de la compilation"/>
     </a>
+    <img src="https://img.shields.io/endpoint?url=https://gist.github.com/clubapplets-server/e51406de3b919a69f396642a2bcb413c/raw/notre_dame_master_badge_coverage.json" alt="Code coverage"/>
     <br />
   </p>
 </div>

README.md

@@ -5,14 +5,17 @@
     <br />
     <br />
     <a href="https://github.com/ApplETS/Notre-Dame/actions/workflows/main-workflow.yaml" style="text-decoration: none;">
-        <img src="https://github.com/ApplETS/Notre-Dame/actions/workflows/main-workflow.yaml/badge.svg?event=push&branch=master" alt="Build Status"/>
-        <img src="https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/apomalyn/63e992d7042dbac4db9abaecb78df0eb/raw/notre_dame_master_badge_coverage.json" alt="Code coverage"/>
+        <img src="https://github.com/ApplETS/Notre-Dame/actions/workflows/main-workflow.yaml/badge.svg?branch=master" alt="Build Status"/>
     </a>
+    <img src="https://img.shields.io/endpoint?url=https://gist.github.com/clubapplets-server/e51406de3b919a69f396642a2bcb413c/raw/notre_dame_master_badge_coverage.json" alt="Code coverage"/>
     <br />
   </p>
 </div>
 
-This project is the placeholder for the fourth version of ÉTSMobile, a mobile which application that is currently available for Android and iOS. ÉTSMobile is the main gateway between the user and the [École de technologie supérieure (ÉTS)](https://www.etsmtl.ca/) on mobile devices. ÉTSMobile is an open-source project and is developped by members of the student club [ApplETS](https://clubapplets.ca/). It offers:
+This project is the placeholder for the fourth version of ÉTSMobile, a mobile which application that is currently
+available for Android and iOS. ÉTSMobile is the main gateway between the user and
+the [École de technologie supérieure (ÉTS)](https://www.etsmtl.ca/) on mobile devices. ÉTSMobile is an open-source
+project and is developped by members of the student club [ApplETS](https://clubapplets.ca/). It offers:
 
 * Access to evaluation grades
 * Access to the student's schedules
@@ -31,29 +34,38 @@ _Note: This guide is also available in: [Français](https://github.com/ApplETS/N
 
 ## Before running the code
 
-- To access some features you will need the SignetsAPI certificate, these files are encrypted. To decrypt them you will need to execute the `env_variables.sh` script (only available on the Google Drive of the club), then run:
+- To access some features you will need the SignetsAPI certificate, these files are encrypted. To decrypt them you will
+  need to execute the `env_variables.sh` script (only available on the Google Drive of the club), then run:
+
 ```
 chmod +x ./scripts/decrypt.sh
 ./scripts/decrypt.sh
 ```
 
 ## Run the code
 
-- After cloning the repo, you will have to get the packages and generate the l10n classes. To do that run the following command:
+- After cloning the repo, you will have to get the packages and generate the l10n classes. To do that run the following
+  command:
+
 ```
 flutter pub get
 ```
 
 ## Add environment variable for API_KEY
-- To add the Google Maps API TOKEN and the GitHub API TOKEN, you need to rename the file `.env.template` into `.env`.
-In the `.env` file, you need to paste the Google Maps API TOKEN and the GitHub API TOKEN.
+
+- To add the Google Maps API TOKEN and the GitHub API TOKEN, you need to rename the file `.env.template` into `.env`. In
+  the `.env` file, you need to paste the Google Maps API TOKEN and the GitHub API TOKEN.
+
 ## Git hooks
 
-You can find under the folder `.githooks` all the hooks needed for this project. To configure git to use this folder enter the following command:
+You can find under the folder `.githooks` all the hooks needed for this project. To configure git to use this folder
+enter the following command:
+
 ```bash
 git config core.hooksPath .githooks
 ```
 
-
 ## ⚖️ License
-This projet is licensed under the Apache License V2.0. See the [LICENSE](https://github.com/ApplETS/Notre-Dame/blob/master/LICENSE) file for more info.
+
+This projet is licensed under the Apache License V2.0. See
+the [LICENSE](https://github.com/ApplETS/Notre-Dame/blob/master/LICENSE) file for more info.

android/app/build.gradle

@@ -67,3 +67,4 @@ dependencies {
 }
 
 apply plugin: 'com.google.gms.google-services'
+apply plugin: 'com.google.firebase.crashlytics'

android/build.gradle

@@ -9,7 +9,7 @@ buildscript {
         classpath 'com.android.tools.build:gradle:4.0.1'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
         classpath 'com.google.gms:google-services:4.3.3'
-        classpath 'com.google.firebase:firebase-crashlytics-gradle:2.2.0'
+        classpath 'com.google.firebase:firebase-crashlytics-gradle:2.5.1'
     }
 }
 

ios/Podfile.lock

@@ -12,14 +12,14 @@ PODS:
   - Firebase/Crashlytics (8.0.0):
     - Firebase/CoreOnly
     - FirebaseCrashlytics (~> 8.0.0)
-  - firebase_analytics (8.1.0):
+  - firebase_analytics (8.1.2):
     - Firebase/Analytics (= 8.0.0)
     - firebase_core
     - Flutter
   - firebase_core (1.3.0):
     - Firebase/CoreOnly (= 8.0.0)
     - Flutter
-  - firebase_crashlytics (2.0.4):
+  - firebase_crashlytics (2.0.6):
     - Firebase/Crashlytics (= 8.0.0)
     - firebase_core
     - Flutter
@@ -229,9 +229,9 @@ EXTERNAL SOURCES:
 SPEC CHECKSUMS:
   connectivity: c4130b2985d4ef6fd26f9702e886bd5260681467
   Firebase: 73c3e3b216ec1ecbc54d2ffdd4670c65c749edb1
-  firebase_analytics: 221d3bc4e8f1b5144a4bd4cc6b33790ee51bd543
+  firebase_analytics: 5e1820ff8ca6cc984fd4d1dedd2dd45965b91535
   firebase_core: cda81ae37eda6df2bc2d16027fda527987c4bd33
-  firebase_crashlytics: 4f3ce855ce6116de954cde34f88003df8ed9de4a
+  firebase_crashlytics: 1dad18971e1bac07bbd560c7a344df391a3a833c
   FirebaseAnalytics: dcb92c7c9ef4fa7ffac276e8f87bd4fc8c97f1b8
   FirebaseCore: 3f09591d51292843e2a46f18358d60bf4e996255
   FirebaseCoreDiagnostics: a31d987ba0fe16d59886a5dbadc2f1de871f88c8

ios/Runner.xcodeproj/project.pbxproj

@@ -542,6 +542,7 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = LaunchImage;
 				CLANG_ENABLE_MODULES = YES;
 				CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)";
+				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				DEVELOPMENT_TEAM = N742HF354K;
 				ENABLE_BITCODE = NO;
 				FRAMEWORK_SEARCH_PATHS = (

lib/core/managers/cache_manager.dart

@@ -46,9 +46,12 @@ class CacheManager {
     try {
       await _cacheManager.putFile(
           key, UriData.fromString(value, encoding: utf8).contentAsBytes());
-    } on Exception catch (e) {
+    } on Exception catch (e, stacktrace) {
       _analyticsService.logError(
-          tag, "Exception raised during cache update of $key: ${e.toString()}");
+          tag,
+          "Exception raised during cache update of $key: ${e.toString()}",
+          e,
+          stacktrace);
       rethrow;
     }
   }
@@ -57,19 +60,22 @@ class CacheManager {
   Future delete(String key) async {
     try {
       await _cacheManager.removeFile(key);
-    } on Exception catch (e) {
+    } on Exception catch (e, stacktrace) {
       _analyticsService.logError(
-          tag, "Exception raised during cache delete of $key: ${e.toString()}");
+          tag,
+          "Exception raised during cache delete of $key: ${e.toString()}",
+          e,
+          stacktrace);
     }
   }
 
   /// Empty the cache
   Future empty() async {
     try {
       await _cacheManager.emptyCache();
-    } on Exception catch (e) {
+    } on Exception catch (e, stacktrace) {
       _analyticsService.logError(
-          tag, "Exception raised during emptying cache: $e");
+          tag, "Exception raised during emptying cache: $e", e, stacktrace);
       rethrow;
     }
   }

lib/core/managers/course_repository.dart

@@ -132,9 +132,9 @@ class CourseRepository {
         _logger.d(
             "$tag - getCoursesActivities: fetched ${fetchedCoursesActivities.length} activities.");
       }
-    } on Exception catch (e) {
-      _analyticsService.logError(
-          tag, "Exception raised during getCoursesActivities: $e");
+    } on Exception catch (e, stacktrace) {
+      _analyticsService.logError(tag,
+          "Exception raised during getCoursesActivities: $e", e, stacktrace);
       _logger.d("$tag - getCoursesActivities: Exception raised $e");
       rethrow;
     }
@@ -203,9 +203,9 @@ class CourseRepository {
       _logger.e(
           "$tag - getSessions: exception raised will trying to update the cache.");
       return _sessions;
-    } on Exception catch (e) {
+    } on Exception catch (e, stacktrace) {
       _analyticsService.logError(
-          tag, "Exception raised during getSessions: $e");
+          tag, "Exception raised during getSessions: $e", e, stacktrace);
       rethrow;
     }
 
@@ -253,8 +253,9 @@ class CourseRepository {
           username: _userRepository.monETSUser.universalCode,
           password: password));
       _logger.d("$tag - getCourses: fetched ${fetchedCourses.length} courses.");
-    } on Exception catch (e) {
-      _analyticsService.logError(tag, "Exception raised during getCourses: $e");
+    } on Exception catch (e, stacktrace) {
+      _analyticsService.logError(
+          tag, "Exception raised during getCourses: $e", e, stacktrace);
       _logger.e("$tag - getCourses: Exception raised $e");
       rethrow;
     }
@@ -315,15 +316,15 @@ class CourseRepository {
           password: password,
           course: course);
       _logger.d("$tag - getCourseSummary: fetched ${course.acronym} summary.");
-    } on Exception catch (e) {
+    } on Exception catch (e, stacktrace) {
       if (e is ApiException) {
         if (e.errorCode == SignetsError.gradesEmpty) {
           _logger.e(
               "$tag - getCourseSummary: Summary is empty for ${course.acronym}.");
           return null;
         }
       }
-      _analyticsService.logError(tag, e.toString());
+      _analyticsService.logError(tag, e.toString(), e, stacktrace);
       _logger.e("$tag - getCourseSummary: Exception raised $e");
       rethrow;
     }

lib/core/managers/user_repository.dart

@@ -82,8 +82,9 @@ class UserRepository {
     try {
       _monETSUser =
           await _monETSApi.authenticate(username: username, password: password);
-    } catch (e) {
-      _analyticsService.logError(tag, "Authenticate - ${e.toString()}");
+    } on Exception catch (e, stacktrace) {
+      _analyticsService.logError(
+          tag, "Authenticate - ${e.toString()}", e, stacktrace);
       return false;
     }
 
@@ -95,9 +96,12 @@ class UserRepository {
       try {
         await _secureStorage.write(key: usernameSecureKey, value: username);
         await _secureStorage.write(key: passwordSecureKey, value: password);
-      } on PlatformException catch (e) {
+      } on PlatformException catch (e, stacktrace) {
         _analyticsService.logError(
-            tag, "Authenticate - PlatformException - ${e.toString()}");
+            tag,
+            "Authenticate - PlatformException - ${e.toString()}",
+            e,
+            stacktrace);
         return false;
       }
     }
@@ -128,9 +132,9 @@ class UserRepository {
     try {
       await _secureStorage.delete(key: usernameSecureKey);
       await _secureStorage.delete(key: passwordSecureKey);
-    } on PlatformException catch (e) {
-      _analyticsService.logError(
-          tag, "Authenticate - PlatformException - ${e.toString()}");
+    } on PlatformException catch (e, stacktrace) {
+      _analyticsService.logError(tag,
+          "Authenticate - PlatformException - ${e.toString()}", e, stacktrace);
       return false;
     }
     return true;
@@ -209,9 +213,9 @@ class UserRepository {
       _logger.e(
           "$tag - getPrograms: exception raised while trying to update the cache.");
       return _programs;
-    } on Exception catch (e) {
+    } on Exception catch (e, stacktrace) {
       _analyticsService.logError(
-          tag, "Exception raised during getPrograms: $e");
+          tag, "Exception raised during getPrograms: $e", e, stacktrace);
       rethrow;
     }
 
@@ -265,8 +269,9 @@ class UserRepository {
       _logger.e(
           "$tag - getInfo: exception raised while trying to update the cache.");
       return _info;
-    } on Exception catch (e) {
-      _analyticsService.logError(tag, "Exception raised during getInfo: $e");
+    } on Exception catch (e, stacktrace) {
+      _analyticsService.logError(
+          tag, "Exception raised during getInfo: $e", e, stacktrace);
       rethrow;
     }