Bugfix/overscroll color (#163)

* fixed overscroll color

* changed overscroll behavior, was not the width of parent

* fixed grades higher than 100% error

* fixed error message when grades not available

* updated version

* added test for isBusy

Author: AlexandreMarkus

lib/core/managers/course_repository.dart

@@ -318,7 +318,8 @@ class CourseRepository {
       _logger.d("$tag - getCourseSummary: fetched ${course.acronym} summary.");
     } on Exception catch (e, stacktrace) {
       if (e is ApiException) {
-        if (e.errorCode == SignetsError.gradesEmpty) {
+        if (e.errorCode == SignetsError.gradesEmpty ||
+            e.message.startsWith(SignetsError.gradesNotAvailable)) {
           _logger.e(
               "$tag - getCourseSummary: Summary is empty for ${course.acronym}.");
           return null;

lib/ui/utils/app_theme.dart

@@ -37,7 +37,8 @@ class AppTheme {
     return lightTheme.copyWith(
         primaryColor: etsLightRed,
         accentColor: etsLightRed,
-        colorScheme: lightTheme.colorScheme.copyWith(primary: etsLightRed),
+        colorScheme: lightTheme.colorScheme
+            .copyWith(primary: etsLightRed, secondary: etsLightRed),
         bottomNavigationBarTheme: lightTheme.bottomNavigationBarTheme
             .copyWith(selectedItemColor: etsLightRed));
   }
@@ -51,7 +52,8 @@ class AppTheme {
         scaffoldBackgroundColor: const Color(0xff121212),
         cardColor: const Color(0xff1e1e1e),
         accentColor: etsLightRed,
-        colorScheme: darkTheme.colorScheme.copyWith(primary: etsLightRed),
+        colorScheme: darkTheme.colorScheme
+            .copyWith(primary: etsLightRed, secondary: etsLightRed),
         bottomNavigationBarTheme: darkTheme.bottomNavigationBarTheme
             .copyWith(selectedItemColor: etsLightRed));
   }

lib/ui/views/dashboard_view.dart

@@ -83,7 +83,7 @@ class _DashboardViewState extends State<DashboardView>
                       child: ReorderableListView(
                         onReorder: (oldIndex, newIndex) =>
                             onReorder(model, oldIndex, newIndex),
-                        padding: const EdgeInsets.fromLTRB(8, 4, 8, 8),
+                        padding: const EdgeInsets.fromLTRB(0, 4, 0, 8),
                         children: _buildCards(model),
                       ),
                     ));

lib/ui/widgets/dismissible_card.dart

@@ -28,7 +28,7 @@ class DismissibleCard extends StatelessWidget {
       child: Card(
         elevation: elevation,
         color: cardColor,
-        margin: const EdgeInsets.fromLTRB(0, 4, 0, 4),
+        margin: const EdgeInsets.fromLTRB(8, 4, 8, 4),
         child: Stack(children: [
           child,
           if (isBusy)

lib/ui/widgets/grade_circular_progress.dart

@@ -91,7 +91,8 @@ class _GradeCircularProgressState extends State<GradeCircularProgress>
     );
   }
 
-  double getGradeInDecimals(double grade) => grade / 100;
+  double getGradeInDecimals(double grade) =>
+      (grade / 100) > 1.0 ? 1.0 : (grade / 100);
 
   String getGrade(BuildContext context) {
     if (widget.finalGrade != null) {

pubspec.yaml

@@ -15,7 +15,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 # In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
 # Read more about iOS versioning at
 # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
-version: 4.1.0+1
+version: 4.1.1+1
 
 environment:
   sdk: ">=2.10.0 <3.0.0"

test/ui/widgets/dismissible_card_test.dart

@@ -18,5 +18,15 @@ void main() {
 
       expect(find.text(cardText), findsOneWidget);
     });
+    testWidgets("isBusy", (WidgetTester tester) async {
+      await tester.pumpWidget(localizedWidget(
+          child: DismissibleCard(
+              isBusy: true,
+              onDismissed: (DismissDirection direction) {},
+              child: const Text(cardText))));
+
+      expect(find.text(cardText), findsOneWidget);
+      expect(find.byType(CircularProgressIndicator), findsOneWidget);
+    });
   });
 }