Remove percentage (#215)

* Remove percentage

* [CI UPDATE GOLDENS]

* Fix test

* [CI UPDATE GOLDENS]

* Update golden files

Co-authored-by: camillebrulotte <camillebrulotte@users.noreply.github.com>

Author: camillebrulotte

lib/core/utils/utils.dart

@@ -20,7 +20,7 @@ mixin Utils {
       return 0.0;
     }
 
-    return ((grade / maxGrade) * 100).roundToDouble();
+    return double.parse(((grade / maxGrade) * 100).toStringAsFixed(1));
   }
 
   static Color getColorByBrightness(

lib/ui/views/grade_details_view.dart

@@ -214,7 +214,9 @@ class _GradesDetailsViewState extends State<GradesDetailsView>
                           context,
                           model.course.summary.median.toString(),
                           AppIntl.of(context).grades_grade_in_percentage(
-                              model.course.summary.median),
+                              Utils.getGradeInPercentage(
+                                  model.course.summary.median,
+                                  model.course.summary.markOutOf)),
                         ),
                       ),
                     ),

lib/ui/widgets/grade_evaluation_tile.dart

@@ -196,8 +196,15 @@ class _GradeEvaluationTileState extends State<GradeEvaluationTile>
                     evaluation.correctedEvaluationOutOfFormatted),
               ),
             ),
-            _buildSummary(AppIntl.of(context).grades_median,
-                validateResult(context, evaluation.median.toString())),
+            _buildSummary(
+              AppIntl.of(context).grades_median,
+              AppIntl.of(context).grades_grade_with_percentage(
+                evaluation.median ?? 0.0,
+                evaluation.correctedEvaluationOutOf ?? 0.0,
+                Utils.getGradeInPercentage(evaluation.median,
+                    evaluation.correctedEvaluationOutOfFormatted),
+              ),
+            ),
             _buildSummary(
                 AppIntl.of(context).grades_standard_deviation,
                 validateResult(

pubspec.yaml

@@ -15,7 +15,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 # In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
 # Read more about iOS versioning at
 # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
-version: 4.2.3+1
+version: 4.2.4+1
 
 environment:
   sdk: ">=2.10.0 <3.0.0"

test/ui/views/goldenFiles/gradesDetailsView_1.png

@@ -108,11 +108,11 @@ void main() {
         expect(label2, findsOneWidget);
 
         final label3 = find.text(intl.grades_not_available);
-        //grades_median, grades_standard_deviation, grades_percentile_rank
-        expect(label3, findsNWidgets(3));
+        //grades_standard_deviation, grades_percentile_rank
+        expect(label3, findsNWidgets(2));
 
         final label4 = find.text("0.0/30 (0.0%)");
-        expect(label4, findsNWidgets(2));
+        expect(label4, findsNWidgets(3));
       });
     });
   });

test/ui/views/goldenFiles/gradesDetailsView_2.png

@@ -380,7 +380,6 @@ void main() {
             PreferencesFlag.scheduleCard);
         SettingsManagerMock.stubSetInt(settingsManager as SettingsManagerMock,
             PreferencesFlag.progressBarCard);
-
         SettingsManagerMock.stubGetDashboard(
             settingsManager as SettingsManagerMock,
             toReturn: dashboard);