Skip to content

Commit 81ee1db

Browse files
Samueru-samaTheAssassin
authored andcommitted
Use default block size with zstd compression
1 parent 55fc58b commit 81ee1db

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/appimagetool.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,12 +156,13 @@ int sfs_mksquashfs(char *source, char *destination, int offset) {
156156
args[i++] = "16384";
157157
} else if (strcmp(sqfs_comp, "zstd") == 0) {
158158
/*
159-
* > Build with 1MiB block size
160-
* > Using a bigger block size than mksquashfs's default improves read speed and can produce smaller AppImages as well
161-
* -- https://github.com/probonopd/go-appimage/commit/c4a112e32e8c2c02d1d388c8fa45a9222a529af3
159+
* > Build with default 128K block size
160+
* > It used to be 1M but that actually causes much higher startup times.
161+
* > Some testing might be needed to see if there is some other value that actually improves performance.
162+
* -- https://github.com/AppImage/appimagetool/issues/64
162163
*/
163164
args[i++] = "-b";
164-
args[i++] = "1M";
165+
args[i++] = "128K";
165166
}
166167

167168
// check if ignore file exists and use it if possible

0 commit comments

Comments
 (0)