Minor fixes on macos

Author: AntonisZks

.gitignore

@@ -9,3 +9,4 @@ data/Dummy/dummy-groundtruth*.bin
 *.bin
 .idea
 venv
+.DS_Store

include/distance.h

@@ -42,7 +42,7 @@ struct EuclideanDistanceOrder {
    * 
    * @return True if the first element is closer to the target vector than the second element.
    */
-  bool operator()(const base_t& a, const base_t& b);
+  bool operator()(const base_t& a, const base_t& b) const;
 
 };
 

src/DataReaders/read_vectors.cpp

@@ -78,7 +78,6 @@ vector<DataVector<int>> ReadGroundTruth(const string& filename) {
     }
 
     vector<DataVector<int>> dataVectors; // Vector to store DataVector objects
-    int nb_vectors = 0;
 
     while (file) {
         int d;  // Dimensionality of the vector (first 4 bytes)
@@ -101,7 +100,6 @@ vector<DataVector<int>> ReadGroundTruth(const string& filename) {
 
         // Add the DataVector object to the vector
         dataVectors.push_back(dataVector);
-        nb_vectors++;
     }
 
     file.close();

src/Geometry/distance_functions.cpp

@@ -15,7 +15,8 @@ using namespace std;
  * 
  * @return True if the first element is closer to the target vector than the second element.
  */
-template <typename base_t, typename query_t> bool EuclideanDistanceOrder<base_t, query_t>::operator()(const base_t& a, const base_t& b) {
+template <typename base_t, typename query_t> 
+bool EuclideanDistanceOrder<base_t, query_t>::operator()(const base_t& a, const base_t& b) const {
 
     double distanceA, distanceB;
 

src/Graph/graph_node.cpp

@@ -38,12 +38,12 @@ template <typename node_t> void GraphNode<node_t>::removeNeighbor(node_t data) {
 
 }
 
-template class GraphNode<int>;
-template class GraphNode<double>;
-template class GraphNode<std::string>;
-
-template class GraphNode<DataVector<float>>;
-template class GraphNode<DataVector<double>>;
-template class GraphNode<BaseDataVector<float>>;
-template class GraphNode<BaseDataVector<double>>;
+template struct GraphNode<int>;
+template struct GraphNode<double>;
+template struct GraphNode<std::string>;
+
+template struct GraphNode<DataVector<float>>;
+template struct GraphNode<DataVector<double>>;
+template struct GraphNode<BaseDataVector<float>>;
+template struct GraphNode<BaseDataVector<double>>;
 

src/VIA/Algorithms/GreedySearch.cpp

@@ -77,7 +77,6 @@ GreedySearch(const VamanaIndex<graph_t>& index, const GraphNode<graph_t>& s, con
 
   // Calculate initial difference between candidates and visited sets
   std::set<graph_t> candidates_minus_visited = getSetDifference(candidates, visited);
-  unsigned int cnt = 0;
   float p_star_distance = 0, currentDistance = 0;
 
   // Main search loop: continue until there are no unvisited candidates
@@ -136,7 +135,6 @@ GreedySearch(const VamanaIndex<graph_t>& index, const GraphNode<graph_t>& s, con
 
     // Update candidates_minus_visited with the new difference after adding p_star to visited
     candidates_minus_visited = getSetDifference(candidates, visited);
-    cnt++; // Increment loop counter for diagnostics if needed
   }
 
   // Final selection of k closest candidates after main loop