Skip to content

DISMISS doesn't work #48

@Ana06

Description

@Ana06

It seems that the addPullRequestReview mutation doesn't support DISMISS. I think this is a GitHub bug and not a problem in the action itself. But as a result the action is broken. You can check this with the following queries in https://docs.github.com/en/graphql/overview/explorer:

query get_pr_id {
  repository(owner: "Ana06", name: "capa") {
    pullRequest(number: 2) {
      id
      number
      title
    }
  }
}

image

mutation add_review {
  addPullRequestReview(input: {
    pullRequestId: "MDExOlB1bGxSZXF1ZXN0NTk3NzMyNTAx",
    event: REQUEST_CHANGES,
    body: "I request changes!"}
  ) { clientMutationId }
}

image

mutation dismiss_review {
  addPullRequestReview(input: {
    pullRequestId: "MDExOlB1bGxSZXF1ZXN0NTk3NzMyNTAx",
    event: DISMISS,
    body: "I don't request changes!"}) {
    clientMutationId
  }
}

image

I reported it to GitHub 9 days ago. GitHub support has told me to use the dismisspullrequestreview mutation. They are still looking into it, so it might be that they fix addPullRequestReview to support DISMISS. Otherwise we could update the code to use dismisspullrequestreview, as it seems to be working properly. I can send a PR after #47 (to avoid merge conflicts).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions