From 1c62df5adf646a9d1b3be2088d730f51009be82f Mon Sep 17 00:00:00 2001 From: Kevin's Lab <35717985+cold63@users.noreply.github.com> Date: Fri, 14 Jun 2024 17:42:36 +0800 Subject: [PATCH 1/3] Remove the non-existent LED definition. --- Arduino_package/hardware/variants/datalogger_amb26/variant.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/Arduino_package/hardware/variants/datalogger_amb26/variant.h b/Arduino_package/hardware/variants/datalogger_amb26/variant.h index 91e2e282..4eb334ba 100644 --- a/Arduino_package/hardware/variants/datalogger_amb26/variant.h +++ b/Arduino_package/hardware/variants/datalogger_amb26/variant.h @@ -96,9 +96,6 @@ extern void wait_for_debug(void); #define A6 AMB_D9 // PB_3 3.3V CH6 /* LED pin mapping */ -#define LED_G AMB_D3 // Green -#define LED_R AMB_D2 // Red -#define LED_B AMB_D1 // Blue #define LED_BUILTIN LED_G // Green /* ADC/DAC pin mapping */ From f77d6f79fb790d09c67952da271ce0c103c8429d Mon Sep 17 00:00:00 2001 From: Kevin's Lab <35717985+cold63@users.noreply.github.com> Date: Fri, 14 Jun 2024 17:43:33 +0800 Subject: [PATCH 2/3] The definition for AMB_D4 is not connected. --- .../hardware/variants/datalogger_amb26/variant.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Arduino_package/hardware/variants/datalogger_amb26/variant.cpp b/Arduino_package/hardware/variants/datalogger_amb26/variant.cpp index 47f99af7..e6beaa50 100644 --- a/Arduino_package/hardware/variants/datalogger_amb26/variant.cpp +++ b/Arduino_package/hardware/variants/datalogger_amb26/variant.cpp @@ -36,11 +36,7 @@ PinDescription g_APinDescription[TOTAL_GPIO_PIN_NUM]= {PA_14, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_SPI, MODE_NOT_INITIAL}, // AMB_D1 {PA_13, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_UART | PIO_SPI, MODE_NOT_INITIAL}, // AMB_D2 {PA_12, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_UART | PIO_SPI, MODE_NOT_INITIAL}, // AMB_D3 -#ifdef BOARD_AMB26 {NC, NOT_INITIAL, NOT_INITIAL , MODE_NOT_INITIAL}, // AMB_D4 -#else - {PA_30, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM , MODE_NOT_INITIAL}, // AMB_D4 -#endif {PA_28, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM , MODE_NOT_INITIAL}, // AMB_D5 {PA_26, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_IR | PIO_I2C , MODE_NOT_INITIAL}, // AMB_D6 {PA_25, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_IR | PIO_I2C , MODE_NOT_INITIAL}, // AMB_D7 From 51d2125ca5fb8eee5b7b2cf6124700000b279a33 Mon Sep 17 00:00:00 2001 From: Michael Zhang <35476432+M-ichae-l@users.noreply.github.com> Date: Tue, 18 Jun 2024 10:47:42 +0800 Subject: [PATCH 3/3] Update variant.h --- Arduino_package/hardware/variants/datalogger_amb26/variant.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Arduino_package/hardware/variants/datalogger_amb26/variant.h b/Arduino_package/hardware/variants/datalogger_amb26/variant.h index 4eb334ba..58d711bd 100644 --- a/Arduino_package/hardware/variants/datalogger_amb26/variant.h +++ b/Arduino_package/hardware/variants/datalogger_amb26/variant.h @@ -96,7 +96,7 @@ extern void wait_for_debug(void); #define A6 AMB_D9 // PB_3 3.3V CH6 /* LED pin mapping */ -#define LED_BUILTIN LED_G // Green +#define LED_BUILTIN NC /* ADC/DAC pin mapping */ #define FEATURE_ADC