Why are the has add/delete/change permissions set to False in the BaseEventAdmin?

[Mariatta]

In admin/core.py BaseEventAdmin, the permissions are all hardcoded to False.

django-pghistory/pghistory/admin/core.py

Lines 159 to 166 in e991e61

	def has_add_permission(self, request):
	return False
	def has_delete_permission(self, request, obj=None):
	return False
	def has_change_permission(self, request, obj=None):
	return False

May I know what is the reasoning behind it? Should we not add/delete the models through the Admin anymore? If we override this behavior, returning True, would it cause problems with django-pghistory? What's the recommended way if we want to be able to add/edit/delete records in the admin for models using django-pghistory?

Thanks.

[wesleykendall]

I believe the main reason I did this was to discourage manually editing event models.

However, since the introduction of the APPEND_ONLY setting, this allows users to protect their event models from ever being manually edited.

I could see us turning on/off admin functionality based on this setting. In other words, if append-only is enabled, we don't allow delete/change. I'm not sure where I stand on if the "add_permission" should be enabled though. Some people don't ever want to allow manually adding events outside of what changes in the DB.

I assume you desire the ability to manually add/remove/change events?

[Mariatta]

Thanks for the quick and thorough response, and it makes sense not to allow users to perform these things. Didn't know about the APPEND_ONLY setting. I will read the docs more thoroughly. Thank you.

[wesleykendall]

You're welcome! To answer your original question, there's nothing that should go wrong by inheriting and overriding those methods