Description
Adapter
-
ethereum/client.rs
- We return anEwtSigningError
when the wallet sign fails in thesign()
function even though we do not sign an Ethereum Web Token but an Outpace state_root -
ethereum/ewt.rs
- Determine if it's necessary to replace the error in thebase64_decode()
function for thePayload
struct with our own instead ofEwtVerifyError
Ad-view Manager
-
-
serve/src/routes.rs
- Check if thenavigator_language
value in the options is correct -
-
helpers.rs
- Check if the quotes in thefetch_opts
variable are correct
Done in Adview manager serve ads preview #564 -
-
manager.rs
- Check what should happen if no validators are found inget_next_adunit()
for the campaign
Checked this while working on Infinity Behaviour + AdView Manager Tests #566 , there should always be a validator -
-
manager.rs
- Check if there is a scenario in production where theunits_with_price
for a campaign can be modified
Config
ganache.toml
- Check the POST /validator-message route performance, more than 1 second for timeout is a lot!
Primitives
analytics/query.rs
- Make the start
field in the Time
struct either a timestamp or DateTime
string when serializing/deserializing
Mentioned in #493, currently low priority
- -
targeting/input/field.rs
-Balances
enum should dropPublisherEarnedFromCampaign
value - -
targeting/eval.rs
- Check the issue linked above theFunction
enum - -
lib.rs
- Removeallow(unstable_name_collisions)
once num::Integer::div_floor() is fixed - -
unified_num.rs
- Check math and write tests for themod_floor()
,gcd()
,lcm()
,divides()
,is_multiple_of(), and
div_rem()` functions
.divides() is deprecated, should we keep it implemented? - -
cargo.toml
- Change ChannelId Serialize implementation in order to removeserde-hex
How should we serialize it instead?
Sentry
- -
db/analytics.rs
- throw a few more analytics in specific DateHours w/ unique Query and check if it filters the analytics correctly in thetest_get_analytics_in_december()
test - -
db/campaign.rs
- Check and update the statement infetch_campaign()
#571
Needs more research, exporting to a separate issue
db.rs
- Fix error mapping in the create()
function of the Manager
Validator Worker
- -
error.rs
- Add channel, validatorId etc. for theChannelNotIntendedForUs
Error variant in the enum
follower.rs
- Check if we should use the health value when displayingInvalidNewState
- -
follower.rs
- Context for All spender sum Error when overflow occurs in the follower tick
follower.rs
- Should we show the Payout Mismatch between Spent & Earned inon_new_state()
- -
follower.rs
- Add context forproposed_balances.check()
overflow error - -
follower.rs
- Add context for Transition error - -
follower.rs
- Add context for error in Spenders and Earners transition - -
lib.rs
- Double checkget_state_root_hash_returns_correct_hash
test
How should the encoded value be checked?