Merge pull request #355 from AdExNetwork/bugfixes

Bugfixes

Author: elpiel

README.md

@@ -39,7 +39,7 @@ We need two services to be able to run `Sentry`: `Postgres` and `Redis`.
 
 ### Running Redis
 
-`docker run --rm --name adex-validator-redis -d redis`
+`docker run --rm -p 6379:6379 --name adex-validator-redis -d redis`
 
 ### Running Sentry Rest API
 

adapter/src/ethereum.rs

@@ -429,9 +429,9 @@ mod test {
     use crate::EthereumChannel;
     use chrono::{Duration, Utc};
     use hex::FromHex;
-    use primitives::adapter::KeystoreOptions;
     use primitives::config::configuration;
     use primitives::ChannelId;
+    use primitives::{adapter::KeystoreOptions, targeting::Rules};
     use primitives::{ChannelSpec, EventSubmission, SpecValidators, ValidatorDesc};
     use std::convert::TryFrom;
     use web3::types::Address;
@@ -651,13 +651,13 @@ mod test {
             deposit_asset: eth_checksum::checksum(&format!("{:?}", token_contract.address())),
             deposit_amount: 2_000.into(),
             valid_until: Utc::now() + Duration::days(2),
-            targeting_rules: vec![],
+            targeting_rules: Rules::new(),
             spec: ChannelSpec {
                 title: None,
                 validators: SpecValidators::new(leader_validator_desc, follower_validator_desc),
                 max_per_impression: 10.into(),
                 min_per_impression: 10.into(),
-                targeting_rules: vec![],
+                targeting_rules: Rules::new(),
                 event_submission: Some(EventSubmission { allow: vec![] }),
                 created: Utc::now(),
                 active_from: None,

primitives/src/ad_slot.rs

@@ -1,12 +1,15 @@
 use crate::{targeting::Rule, BigNum, ValidatorId};
-use chrono::{DateTime, Utc};
+use chrono::{
+    serde::{ts_milliseconds, ts_milliseconds_option},
+    DateTime, Utc,
+};
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
 
 /// See [AdEx Protocol adSlot.md][protocol] & [adex-models AdSlot.js][adex-models] for more details.
 /// [protocol]: https://github.com/AdExNetwork/adex-protocol/blob/master/adSlot.md
 /// [adex-models]: https://github.com/AdExNetwork/adex-models/blob/master/src/models/AdSlot.js
-#[derive(Serialize, Deserialize, Debug, Clone)]
+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
 #[serde(rename_all = "camelCase")]
 pub struct AdSlot {
     /// valid ipfs hash of spec props below
@@ -32,6 +35,7 @@ pub struct AdSlot {
     /// User address from the session
     pub owner: ValidatorId,
     /// UTC timestamp in milliseconds, used as nonce for escaping duplicated spec ipfs hashes
+    #[serde(with = "ts_milliseconds")]
     pub created: DateTime<Utc>,
     /// the name of the unit used in platform UI
     #[serde(default)]
@@ -45,5 +49,6 @@ pub struct AdSlot {
     #[serde(default)]
     pub archived: bool,
     /// UTC timestamp in milliseconds, changed every time modifiable property is changed
+    #[serde(with = "ts_milliseconds_option")]
     pub modified: Option<DateTime<Utc>>,
 }

primitives/src/ad_unit.rs

@@ -1,4 +1,7 @@
-use chrono::{DateTime, Utc};
+use chrono::{
+    serde::{ts_milliseconds, ts_milliseconds_option},
+    DateTime, Utc,
+};
 use serde::{Deserialize, Serialize};
 
 use crate::{ValidatorId, IPFS};
@@ -25,18 +28,27 @@ pub struct AdUnit {
     /// Advertised URL
     pub target_url: String,
     /// Number; minimum targeting score (optional)
+    #[serde(default, skip_serializing_if = "Option::is_none")]
     pub min_targeting_score: Option<f64>,
     /// user address from the session
     pub owner: ValidatorId,
     /// number, UTC timestamp in milliseconds, used as nonce for escaping duplicated spec ipfs hashes
+    #[serde(with = "ts_milliseconds")]
     pub created: DateTime<Utc>,
     /// the name of the unit used in platform UI
+    #[serde(default, skip_serializing_if = "Option::is_none")]
     pub title: Option<String>,
     /// arbitrary text used in platform UI
+    #[serde(default, skip_serializing_if = "Option::is_none")]
     pub description: Option<String>,
     /// user can change it - used for filtering in platform UI
     #[serde(default)]
     pub archived: bool,
     /// UTC timestamp in milliseconds, changed every time modifiable property is changed
+    #[serde(
+        default,
+        with = "ts_milliseconds_option",
+        skip_serializing_if = "Option::is_none"
+    )]
     pub modified: Option<DateTime<Utc>>,
 }

primitives/src/channel.rs

@@ -8,7 +8,7 @@ use chrono::{DateTime, Utc};
 use serde::{Deserialize, Deserializer, Serialize};
 use serde_hex::{SerHex, StrictPfx};
 
-use crate::{targeting::Rule, AdUnit, BigNum, EventSubmission, ValidatorDesc, ValidatorId};
+use crate::{targeting::Rules, AdUnit, BigNum, EventSubmission, ValidatorDesc, ValidatorId};
 use hex::{FromHex, FromHexError};
 
 #[derive(Serialize, Deserialize, PartialEq, Eq, Copy, Clone, Hash)]
@@ -96,7 +96,7 @@ pub struct Channel {
     #[serde(with = "ts_seconds")]
     pub valid_until: DateTime<Utc>,
     #[serde(default)]
-    pub targeting_rules: Vec<Rule>,
+    pub targeting_rules: Rules,
     pub spec: ChannelSpec,
 }
 
@@ -181,7 +181,7 @@ pub struct ChannelSpec {
     #[serde(default, skip_serializing_if = "Vec::is_empty")]
     pub ad_units: Vec<AdUnit>,
     #[serde(default)]
-    pub targeting_rules: Vec<Rule>,
+    pub targeting_rules: Rules,
 }
 
 #[derive(Serialize, Deserialize, Debug, Clone, Eq, PartialEq)]
@@ -370,7 +370,7 @@ mod test {
 pub mod postgres {
     use super::ChannelId;
     use super::{Channel, ChannelSpec};
-    use crate::targeting::Rule;
+    use crate::targeting::Rules;
     use bytes::BytesMut;
     use hex::FromHex;
     use postgres_types::{accepts, to_sql_checked, FromSql, IsNull, Json, ToSql, Type};
@@ -385,7 +385,7 @@ pub mod postgres {
                 deposit_asset: row.get("deposit_asset"),
                 deposit_amount: row.get("deposit_amount"),
                 valid_until: row.get("valid_until"),
-                targeting_rules: row.get::<_, Json<Vec<Rule>>>("targeting_rules").0,
+                targeting_rules: row.get::<_, Json<Rules>>("targeting_rules").0,
                 spec: row.get::<_, Json<ChannelSpec>>("spec").0,
             }
         }