fix: improve error handling and telemetry in image sync

Author: kamushadenes

internal/sync/images.go

@@ -208,9 +208,10 @@ func SyncImage(ctx context.Context, image *structs.Image) error {
 					return nil
 				}
 				if err := push(ctx, image, desc, dst, tag); err != nil {
-					log.Error().Err(err).Msg("Failed to push tag")
+					return err
 				}
-				return err
+
+				return nil
 			}
 
 			return nil
@@ -222,6 +223,23 @@ func SyncImage(ctx context.Context, image *structs.Image) error {
 				Msg("Failed to sync tag")
 
 			telemetry.Errors.Add(ctx, 1,
+				metric.WithAttributes(
+					attribute.KeyValue{
+						Key:   "image",
+						Value: attribute.StringValue(image.Source),
+					},
+					attribute.KeyValue{
+						Key:   "tag",
+						Value: attribute.StringValue(tag),
+					},
+					attribute.KeyValue{
+						Key:   "error",
+						Value: attribute.StringValue(err.Error()),
+					},
+				),
+			)
+		} else {
+			telemetry.Syncs.Add(ctx, 1,
 				metric.WithAttributes(
 					attribute.KeyValue{
 						Key:   "image",
@@ -233,8 +251,6 @@ func SyncImage(ctx context.Context, image *structs.Image) error {
 					},
 				),
 			)
-
-			return err
 		}
 	}
 

internal/telemetry/metrics.go

@@ -10,3 +10,7 @@ var meter = otel.Meter("docker-sync")
 var Errors = must(meter.Int64Counter("errors",
 	metric.WithDescription("The total number of errors"),
 ))
+
+var Syncs = must(meter.Int64Counter("syncs",
+	metric.WithDescription("The total number of syncs"),
+))