improved exception handling in run results

Author: mdesmet

package-lock.json

@@ -13,7 +13,7 @@
   "bugs": {
     "url": "https://github.com/innoverio/vscode-dbt-power-user/issues"
   },
-  "version": "0.4.7",
+  "version": "0.4.8",
   "engines": {
     "vscode": "^1.52.0"
   },

package.json

@@ -53,11 +53,14 @@ export class ManifestParser {
       macros
     );
     const sourceMetaMapPromise = this.sourceParser.createSourceMetaMap(sources);
+
     const runResultMetaMapPromise = this.runResultsParser.createRunResultMetaMap(
       projectRoot,
-      targetPath
+      targetPath,
+      nodes
     );
 
+
     const [
       modelMetaMap,
       macroMetaMap,

src/manifest/parsers/index.ts

@@ -3,40 +3,53 @@ import { provide } from "inversify-binding-decorators";
 import * as path from "path";
 import { Uri } from "vscode";
 import { RunResultMetaMap } from "../../domain";
+import { Reporter } from "../../reporter";
 import { DBTProject } from "../dbtProject";
 
 @provide(RunResultsParser)
 export class RunResultsParser {
-  createRunResultMetaMap(projectRoot: Uri, targetPath: string): Promise<RunResultMetaMap> {
+  constructor(private reporter: Reporter) {}
+
+  createRunResultMetaMap(
+    projectRoot: Uri,
+    targetPath: string,
+    nodes: any
+  ): Promise<RunResultMetaMap> {
     return new Promise((resolve) => {
+
       const runResultMetaMap: RunResultMetaMap = new Map();
-      const runResultPath = path.join(
-        projectRoot.fsPath,
-        targetPath,
-        DBTProject.RUN_RESULTS_FILE
-      );
-      if (!existsSync(runResultPath)) {
-        resolve(runResultMetaMap);
-      }
-      const runResultFile = JSON.parse(readFileSync(runResultPath, "utf8"));
-      const { results, generated_at } = runResultFile;
-      results.forEach((result: any) => {
-        const {
-          node: { root_path, build_path, original_file_path, compiled },
-          error,
-          status,
-        } = result;
-        const fullPath = path.join(root_path, original_file_path);
-        const compiledPath =
-          build_path !== null ? path.join(root_path, build_path) : undefined;
-        runResultMetaMap.set(fullPath, {
-          compiledPath,
-          error,
-          timestamp: generated_at,
-          status,
+      try {
+        const runResultPath = path.join(
+          projectRoot.fsPath,
+          targetPath,
+          DBTProject.RUN_RESULTS_FILE
+        );
+        if (!existsSync(runResultPath)) {
+          resolve(runResultMetaMap);
+        }
+        const runResultFile = JSON.parse(readFileSync(runResultPath, "utf8"));
+        const { results, generated_at } = runResultFile;
+        results.forEach((result: any) => {
+          const {
+            node: { root_path, build_path, original_file_path, compiled },
+            error,
+            status,
+          } = result;
+          const fullPath = path.join(root_path, original_file_path);
+          const compiledPath =
+            build_path !== null ? path.join(root_path, build_path) : undefined;
+          runResultMetaMap.set(fullPath, {
+            compiledPath,
+            error,
+            timestamp: generated_at,
+            status,
+          });
         });
-      });
-      resolve(runResultMetaMap);
+        resolve(runResultMetaMap);
+      }catch(error) {
+        this.reporter.sendException(error);
+        resolve(runResultMetaMap);
+      }      
     });
   }
 }

src/manifest/parsers/runResultsParser.ts

@@ -68,7 +68,7 @@ abstract class ModelTreeviewProvider
       return Promise.resolve([]);
     }
 
-    const currentFilePath = window.activeTextEditor!.document.uri;
+    const currentFilePath = window.activeTextEditor.document.uri;
     const projectRootpath = this.dbtProjectContainer.getProjectRootpath(
       currentFilePath
     );