Skip to content

Commit f5711f9

Browse files
hcahcaVasily Gorbik
authored andcommitted
s390: remove WARN_DYNAMIC_STACK
s390 is the only architecture which allows to set the -mwarn-dynamicstack compile option. This however will also always generate a warning with system call stack randomization, which uses alloca to generate some random sized stack frame. On the other hand Linus just enabled "-Werror" by default with commit 3fe617c ("Enable '-Werror' by default for all kernel builds"), which means compiles will always fail by default. So instead of playing once again whack-a-mole for something which is s390 specific, simply remove this option. Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
1 parent 948e505 commit f5711f9

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

arch/s390/Kconfig

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -685,16 +685,6 @@ config STACK_GUARD
685685
The minimum size for the stack guard should be 256 for 31 bit and
686686
512 for 64 bit.
687687

688-
config WARN_DYNAMIC_STACK
689-
def_bool n
690-
prompt "Emit compiler warnings for function with dynamic stack usage"
691-
help
692-
This option enables the compiler option -mwarn-dynamicstack. If the
693-
compiler supports this options generates warnings for functions
694-
that dynamically allocate stack space using alloca.
695-
696-
Say N if you are unsure.
697-
698688
endmenu
699689

700690
menu "I/O subsystem"

arch/s390/Makefile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,6 @@ cflags-$(CONFIG_CHECK_STACK) += -mstack-guard=$(CONFIG_STACK_GUARD)
8585
endif
8686
endif
8787

88-
ifdef CONFIG_WARN_DYNAMIC_STACK
89-
ifneq ($(call cc-option,-mwarn-dynamicstack),)
90-
KBUILD_CFLAGS += -mwarn-dynamicstack
91-
KBUILD_CFLAGS_DECOMPRESSOR += -mwarn-dynamicstack
92-
endif
93-
endif
94-
9588
ifdef CONFIG_EXPOLINE
9689
ifneq ($(call cc-option,$(CC_FLAGS_MARCH) -mindirect-branch=thunk),)
9790
CC_FLAGS_EXPOLINE := -mindirect-branch=thunk

0 commit comments

Comments
 (0)