Skip to content

Commit 9848417

Browse files
Sebastian Andrzej SiewiorKAGA-KOKO
authored andcommitted
sched/idle: Make the idle timer expire in hard interrupt context
The intel powerclamp driver will setup a per-CPU worker with RT priority. The worker will then invoke play_idle() in which it remains in the idle poll loop until it is stopped by the timer it started earlier. That timer needs to expire in hard interrupt context on PREEMPT_RT. Otherwise the timer will expire in ksoftirqd as a SOFT timer but that task won't be scheduled on the CPU because its priority is lower than the priority of the worker which is in the idle loop. Always expire the idle timer in hard interrupt context. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/20210906113034.jgfxrjdvxnjqgtmc@linutronix.de
1 parent e681dcb commit 9848417

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/sched/idle.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,10 +379,10 @@ void play_idle_precise(u64 duration_ns, u64 latency_ns)
379379
cpuidle_use_deepest_state(latency_ns);
380380

381381
it.done = 0;
382-
hrtimer_init_on_stack(&it.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
382+
hrtimer_init_on_stack(&it.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
383383
it.timer.function = idle_inject_timer_fn;
384384
hrtimer_start(&it.timer, ns_to_ktime(duration_ns),
385-
HRTIMER_MODE_REL_PINNED);
385+
HRTIMER_MODE_REL_PINNED_HARD);
386386

387387
while (!READ_ONCE(it.done))
388388
do_idle();

0 commit comments

Comments
 (0)