Skip to content

Commit 510e1a7

Browse files
effective-lightChristoph Hellwig
authored andcommitted
dma-debug: prevent an error message from causing runtime problems
For some drivers, that use the DMA API. This error message can be reached several millions of times per second, causing spam to the kernel's printk buffer and bringing the CPU usage up to 100% (so, it should be rate limited). However, since there is at least one driver that is in the mainline and suffers from the error condition, it is more useful to err_printk() here instead of just rate limiting the error message (in hopes that it will make it easier for other drivers that suffer from this issue to be spotted). Link: https://lkml.kernel.org/r/fd67fbac-64bf-f0ea-01e1-5938ccfab9d0@arm.com Reported-by: Jeremy Linton <jeremy.linton@arm.com> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent a61cb60 commit 510e1a7

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kernel/dma/debug.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,8 @@ static void add_dma_entry(struct dma_debug_entry *entry)
567567
pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
568568
global_disable = true;
569569
} else if (rc == -EEXIST) {
570-
pr_err("cacheline tracking EEXIST, overlapping mappings aren't supported\n");
570+
err_printk(entry->dev, entry,
571+
"cacheline tracking EEXIST, overlapping mappings aren't supported\n");
571572
}
572573
}
573574

0 commit comments

Comments
 (0)