Skip to content

Commit 2c57ad6

Browse files
committed
s390/zcrypt: remove incorrect kernel doc indicators
Many comments above functions start with a kernel doc indicator, but the comments are not using kernel doc style. Get rid of the warnings by simply removing the indicator. E.g.: drivers/s390/crypto/zcrypt_msgtype6.c:111: warning: This comment starts with '/**', but isn't a kernel-doc comment. Reviewed-by: Harald Freudenberger <freude@linux.ibm.com> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
1 parent f6beebb commit 2c57ad6

File tree

6 files changed

+48
-48
lines changed

6 files changed

+48
-48
lines changed

drivers/s390/crypto/zcrypt_api.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ static LIST_HEAD(zcrypt_ops_list);
7171
/* Zcrypt related debug feature stuff. */
7272
debug_info_t *zcrypt_dbf_info;
7373

74-
/**
74+
/*
7575
* Process a rescan of the transport layer.
7676
*
7777
* Returns 1, if the rescan has been processed, otherwise 0.
@@ -462,7 +462,7 @@ static void zcdn_destroy_all(void)
462462

463463
#endif
464464

465-
/**
465+
/*
466466
* zcrypt_read (): Not supported beyond zcrypt 1.3.1.
467467
*
468468
* This function is not supported beyond zcrypt 1.3.1.
@@ -473,7 +473,7 @@ static ssize_t zcrypt_read(struct file *filp, char __user *buf,
473473
return -EPERM;
474474
}
475475

476-
/**
476+
/*
477477
* zcrypt_write(): Not allowed.
478478
*
479479
* Write is is not allowed
@@ -484,7 +484,7 @@ static ssize_t zcrypt_write(struct file *filp, const char __user *buf,
484484
return -EPERM;
485485
}
486486

487-
/**
487+
/*
488488
* zcrypt_open(): Count number of users.
489489
*
490490
* Device open function to count number of users.
@@ -512,7 +512,7 @@ static int zcrypt_open(struct inode *inode, struct file *filp)
512512
return stream_open(inode, filp);
513513
}
514514

515-
/**
515+
/*
516516
* zcrypt_release(): Count number of users.
517517
*
518518
* Device close function to count number of users.
@@ -2153,7 +2153,7 @@ static void zcdn_exit(void)
21532153

21542154
#endif
21552155

2156-
/**
2156+
/*
21572157
* zcrypt_api_init(): Module initialization.
21582158
*
21592159
* The module initialization code.
@@ -2191,7 +2191,7 @@ int __init zcrypt_api_init(void)
21912191
return rc;
21922192
}
21932193

2194-
/**
2194+
/*
21952195
* zcrypt_api_exit(): Module termination.
21962196
*
21972197
* The module termination code.

drivers/s390/crypto/zcrypt_cex2a.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ static struct ap_device_id zcrypt_cex2a_queue_ids[] = {
6565

6666
MODULE_DEVICE_TABLE(ap, zcrypt_cex2a_queue_ids);
6767

68-
/**
68+
/*
6969
* Probe function for CEX2A card devices. It always accepts the AP device
7070
* since the bus_match already checked the card type.
7171
* @ap_dev: pointer to the AP device.
@@ -124,7 +124,7 @@ static int zcrypt_cex2a_card_probe(struct ap_device *ap_dev)
124124
return rc;
125125
}
126126

127-
/**
127+
/*
128128
* This is called to remove the CEX2A card driver information
129129
* if an AP card device is removed.
130130
*/
@@ -142,7 +142,7 @@ static struct ap_driver zcrypt_cex2a_card_driver = {
142142
.flags = AP_DRIVER_FLAG_DEFAULT,
143143
};
144144

145-
/**
145+
/*
146146
* Probe function for CEX2A queue devices. It always accepts the AP device
147147
* since the bus_match already checked the queue type.
148148
* @ap_dev: pointer to the AP device.
@@ -183,7 +183,7 @@ static int zcrypt_cex2a_queue_probe(struct ap_device *ap_dev)
183183
return rc;
184184
}
185185

186-
/**
186+
/*
187187
* This is called to remove the CEX2A queue driver information
188188
* if an AP queue device is removed.
189189
*/

drivers/s390/crypto/zcrypt_cex2c.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ static const struct attribute_group cca_queue_attr_grp = {
171171
.attrs = cca_queue_attrs,
172172
};
173173

174-
/**
174+
/*
175175
* Large random number detection function. Its sends a message to a CEX2C/CEX3C
176176
* card to find out if large random numbers are supported.
177177
* @ap_dev: pointer to the AP device.
@@ -237,7 +237,7 @@ static int zcrypt_cex2c_rng_supported(struct ap_queue *aq)
237237
return rc;
238238
}
239239

240-
/**
240+
/*
241241
* Probe function for CEX2C/CEX3C card devices. It always accepts the
242242
* AP device since the bus_match already checked the hardware type.
243243
* @ap_dev: pointer to the AP card device.
@@ -303,7 +303,7 @@ static int zcrypt_cex2c_card_probe(struct ap_device *ap_dev)
303303
return rc;
304304
}
305305

306-
/**
306+
/*
307307
* This is called to remove the CEX2C/CEX3C card driver information
308308
* if an AP card device is removed.
309309
*/
@@ -325,7 +325,7 @@ static struct ap_driver zcrypt_cex2c_card_driver = {
325325
.flags = AP_DRIVER_FLAG_DEFAULT,
326326
};
327327

328-
/**
328+
/*
329329
* Probe function for CEX2C/CEX3C queue devices. It always accepts the
330330
* AP device since the bus_match already checked the hardware type.
331331
* @ap_dev: pointer to the AP card device.
@@ -376,7 +376,7 @@ static int zcrypt_cex2c_queue_probe(struct ap_device *ap_dev)
376376
return rc;
377377
}
378378

379-
/**
379+
/*
380380
* This is called to remove the CEX2C/CEX3C queue driver information
381381
* if an AP queue device is removed.
382382
*/

drivers/s390/crypto/zcrypt_cex4.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ static const struct attribute_group ep11_queue_attr_grp = {
394394
.attrs = ep11_queue_attrs,
395395
};
396396

397-
/**
397+
/*
398398
* Probe function for CEX4/CEX5/CEX6/CEX7 card device. It always
399399
* accepts the AP device since the bus_match already checked
400400
* the hardware type.
@@ -562,7 +562,7 @@ static int zcrypt_cex4_card_probe(struct ap_device *ap_dev)
562562
return rc;
563563
}
564564

565-
/**
565+
/*
566566
* This is called to remove the CEX4/CEX5/CEX6/CEX7 card driver
567567
* information if an AP card device is removed.
568568
*/
@@ -586,7 +586,7 @@ static struct ap_driver zcrypt_cex4_card_driver = {
586586
.flags = AP_DRIVER_FLAG_DEFAULT,
587587
};
588588

589-
/**
589+
/*
590590
* Probe function for CEX4/CEX5/CEX6/CEX7 queue device. It always
591591
* accepts the AP device since the bus_match already checked
592592
* the hardware type.
@@ -652,7 +652,7 @@ static int zcrypt_cex4_queue_probe(struct ap_device *ap_dev)
652652
return rc;
653653
}
654654

655-
/**
655+
/*
656656
* This is called to remove the CEX4/CEX5/CEX6/CEX7 queue driver
657657
* information if an AP queue device is removed.
658658
*/

drivers/s390/crypto/zcrypt_msgtype50.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ MODULE_DESCRIPTION("Cryptographic Accelerator (message type 50), " \
3939
"Copyright IBM Corp. 2001, 2012");
4040
MODULE_LICENSE("GPL");
4141

42-
/**
42+
/*
4343
* The type 50 message family is associated with a CEXxA cards.
4444
*
4545
* The four members of the family are described below.
@@ -136,7 +136,7 @@ struct type50_crb3_msg {
136136
unsigned char message[512];
137137
} __packed;
138138

139-
/**
139+
/*
140140
* The type 80 response family is associated with a CEXxA cards.
141141
*
142142
* Note that all unsigned char arrays are right-justified and left-padded
@@ -188,7 +188,7 @@ unsigned int get_rsa_crt_fc(struct ica_rsa_modexpo_crt *crt, int *fcode)
188188
return 0;
189189
}
190190

191-
/**
191+
/*
192192
* Convert a ICAMEX message to a type50 MEX message.
193193
*
194194
* @zq: crypto queue pointer
@@ -255,7 +255,7 @@ static int ICAMEX_msg_to_type50MEX_msg(struct zcrypt_queue *zq,
255255
return 0;
256256
}
257257

258-
/**
258+
/*
259259
* Convert a ICACRT message to a type50 CRT message.
260260
*
261261
* @zq: crypto queue pointer
@@ -346,7 +346,7 @@ static int ICACRT_msg_to_type50CRT_msg(struct zcrypt_queue *zq,
346346
return 0;
347347
}
348348

349-
/**
349+
/*
350350
* Copy results from a type 80 reply message back to user space.
351351
*
352352
* @zq: crypto device pointer
@@ -418,7 +418,7 @@ static int convert_response_cex2a(struct zcrypt_queue *zq,
418418
}
419419
}
420420

421-
/**
421+
/*
422422
* This function is called from the AP bus code after a crypto request
423423
* "msg" has finished with the reply message "reply".
424424
* It is called from tasklet context.
@@ -457,7 +457,7 @@ static void zcrypt_cex2a_receive(struct ap_queue *aq,
457457

458458
static atomic_t zcrypt_step = ATOMIC_INIT(0);
459459

460-
/**
460+
/*
461461
* The request distributor calls this function if it picked the CEXxA
462462
* device to handle a modexpo request.
463463
* @zq: pointer to zcrypt_queue structure that identifies the
@@ -502,7 +502,7 @@ static long zcrypt_cex2a_modexpo(struct zcrypt_queue *zq,
502502
return rc;
503503
}
504504

505-
/**
505+
/*
506506
* The request distributor calls this function if it picked the CEXxA
507507
* device to handle a modexpo_crt request.
508508
* @zq: pointer to zcrypt_queue structure that identifies the
@@ -547,7 +547,7 @@ static long zcrypt_cex2a_modexpo_crt(struct zcrypt_queue *zq,
547547
return rc;
548548
}
549549

550-
/**
550+
/*
551551
* The crypto operations for message type 50.
552552
*/
553553
static struct zcrypt_ops zcrypt_msgtype50_ops = {

0 commit comments

Comments
 (0)