💡 Enhancement ideas

[ericblade]

If you're interested in some ideas for enhancements, some of which I might be able to contribute to, in the very short time I've been using this :-) i've come up with some ideas that I think would be pretty useful to put into the lib

• add a configuration method for polling document.title (option for a single-time monitor, or check on a defined interval, easy to do with setInterval(() => titlebar.setTitle(), intervalLength) )
• an option to intercept resizeTo() - monkeypatch resizeTo to include space for the title bar
• fix to not blow up completely if remote module is not available
• fix to not even require remote if menu = null
• add a menuPosition: right option
• fix to not totally blow up if icon isn't valid (or maybe that's an error elsewhere in my code.... ?)
• find a way to use the window's defined icon (perhaps could be done with some ipc, i think there's a way to convert the main process's image format into data uri, but not positive...)
• perhaps an option to use favicon as window icon?
• fix it to work in some way if instanced before document loaded? perhaps if whatever it's missing when loaded pre document-load, have it attach a listener to document loaded event to initialize at that point
• update docs to include how to make it work outside of mac
• add some sort of method to easily insert new buttons/controls instead of using an OS menu

... i want to say i had a few other quick ideas, but i can't remember them, this pretty much sums up some early notes/exploration i've done just poking around with it.

To describe what I'm doing with this right now, i'm presently wrapping an existing web application that i do not have control over, and making significant changes to it via a preload script. I suspect as I get into using it more, I might have even more weird ideas :-D

Anyway, figured I'd just throw these all out here, and see if you'd be interested in any of these

[ericblade]

this might be a fix for the preload problem, not sure exactly why it works .. https://github.com/Floffah/custom-electron-titlebar/commit/cc0eacfb65b0b2dbf95b24a967562860332741e8

digging through a lot of the forks... https://github.com/Calyx-/custom-electron-titlebar/commit/9863e12aa39bb077f8b49f7569169f03e14b2995

MairwunNx@dbe838a

MairwunNx@c5ae115

MairwunNx@c5ae115

MairwunNx@ceeefbc

MairwunNx@4af585f

MairwunNx@4649340

This I wouldn't put in, but I'm noting as a possible motivation for adding an ability to add things other than Menus to the titlebar joyoti-disha@368e069

This commit looks a little incompatible, but "adding an inactive background color" is exactly something i had thought of ym1229@1236ed4

One possible way to support custom HTML in the bar, although probably not nearly as comprehensive as it should be warrengalyen@64cb2ea

Here's a rather extensive fix for broken mnemonics that doesn't appear to require having this menu be a duplicate of the system menu: Treverix@ee506cc

Add for unit testing: Treverix@ee506cc

[AlexTorresDev]

I will respond to each of the ideas on the list indicating if it has already been added, is in process or something else.

[ericblade]

If one were to implement a strategy that allowed IPC, you can hook the main window to transmit document.title events ('page-title-updated') and send them to the cet component via ipc, just discovered that event is a thing while reading the docs.. to prevent having to auto-poll for it

[ericblade]

Looks like setting css .container-after-titlebar { overflow: visible; } is likely preferable to overflow: auto, as we probably don't want scrollbars all over the place

[m5x5]

Totally agree with your ideas! 😃 It'd be also nice if we had a documentation on how to style the menu bar(, and perhaps enable donations on the repo).

[ericblade]

I hoped I'd have time to pick a few of these things off quickly, but I don't even have time to handle small things in my own repos right now. A lot of this stuff is easy, and could cherry pick from other places. I don't want to start inserting features without some thought behind them though.....

[m5x5]

Yes, definitely. Maybe we should create issues for this, it seems like discussions don't get enough attention to discuss code changes and recommendations atm 🤔

[AlexTorresDev]

Hi,

The discussions do work, I have been aware of everything, and I apologize for responding so far as I was a bit busy.

I hope I can have time to do some work at the bookstore.

Thanks for the contributions and support