Crash on Multiplayer screen while (failing to?) ping server

[CenTdemeern1]

Modloader

NeoForge

Minecraft Version

1.20.1

Modloader Version

NeoForge 47.1.106

No Chat Reports Version

Forge-1.20.1-v2.2.2

Modpack Info

https://modrinth.com/modpack/roots-1.20.1

The latest.log File

https://mclo.gs/iTc58cs

Bug Description

Failing to ping a server on the multiplayer screen seems to crash the game.

Steps to Reproduce

1. Add a server to the multiplayer screen
2. Sit idle for a while

Other Information

The setup for the server I'm playing on is a bit weird. Might be a bit hard to reproduce, but I can privately share the server IP if you need to reproduce it.

[Tyrthurey]

++ on this, it's happening to me too, here is my modpack: https://gofile.io/d/jv8rqY

[P3rf3ctXZer0]

Me too! https://www.curseforge.com/minecraft/modpacks/fiction-friction-gaming

[ArtOfCombat]

Same. I'll downgrade for now.

[maramowicz]

I feel like No Chat Reports for 1.20.1 was abandoned (and I feel like it's because there's unified branch for whonl 1.20, but ok), even when issue was fixed in newer version of mods in #487

For anyone who need a fixed version I backported that fix to 1.20.1 version of the mod here

Also, for now, that fix is not perfect. That fixes ONLY pinging issue, that means pings on server list works, but from some reason (I'm not 100% sure why but that's technically other issue) server does not sends preventsChatReports so client is not aware that server has mod installed, but setting demandOnClient works correct so I guess server is aware that client has a mod. That means that at least mod works, even if on client there is a warning that server does not have a mod installed. (Edit: I feel like that's #490)

Also, I feel like that fix was needed for at least 1.20.1 (I needed it too), I don't think for now that I need to backport that fix to versions other than 1.20.1.