Skip to content

Breaking changes for new SDK version #181

@unmaykr-aftermath

Description

@unmaykr-aftermath

These should be merged into breaking-changes-park (see the linked branch on the right side panel) once completed. The initial plan is to then merge it all into main once an update to sui-sdk-types comes out, which forces a breaking change on all downstream libraries anyway.

However, if it does get too cumbersome, we can merge these breaking changes separately.

Checklist

Small

  • Remove 'paged' query methods from GraphQlClient trait
  • Remove MoveVec and use #[tabled(format(...))] for vector displays
  • Remove sui_gql_client::queries::GraphQlClientExt: Sized
  • Set static package address and module in the #[derive(MoveStruct)] impl for sui_framework_sdk::object::{ID, UID}
  • Use Rust's Option instead of move_stdlib's option1 @matteo-aftermath
  • chore(deps): update jsonrpsee requirement from 0.24 to 0.25 #184

Large

  • Update tabled and/or derive Display through a proxy private struct that implements Tabled
  • Separate af-gql-client crate to hold RawClient and GraphQlClient traits
  • af-gql-reqwest crate with the corresponding implementations of af-gql-client there
  • af_gql_client::GraphQlClient::page_size -> Option<u32> method

Footnotes

  1. https://github.com/AftermathFinance/aftermath-sdk-rust/pull/189#discussion_r2084248434

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions