Skip to content

Commit febb59b

Browse files
committed
BUG: Fix radial unit vector typos in init_mag_grid
- Sign was wrong - should have been sin^2, not just sin in denominator
1 parent 30fa3dd commit febb59b

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/init_mag_grid.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -483,9 +483,10 @@ bool Grid::init_dipole_grid(Quadtree quadtree_ion, Planets planet) {
483483
gravity_vcgc[iV].zeros();
484484
}
485485

486-
rad_unit_vcgc[1] = cos(magLat_scgc) / pow(abs(1 + 3 * sin(magLat_scgc)), 0.5);
487-
rad_unit_vcgc[2] = -2 * sin(magLat_scgc) / pow(abs(1 + 3 * sin(magLat_scgc)),
488-
0.5);
486+
rad_unit_vcgc[1] = cos(magLat_scgc) / pow(abs(1.0 + 3.0 * sin(magLat_scgc)
487+
% sin(magLat_scgc)), 0.5);
488+
rad_unit_vcgc[2] = 2.0 * sin(magLat_scgc) / pow(abs(1.0 + 3.0 * sin(magLat_scgc)
489+
% sin(magLat_scgc)), 0.5);
489490

490491
precision_t mu = planet.get_mu();
491492
gravity_vcgc[1] = - mu * rad_unit_vcgc[1] % radius2i_scgc;
@@ -494,11 +495,6 @@ bool Grid::init_dipole_grid(Quadtree quadtree_ion, Planets planet) {
494495
gravity_potential_scgc.zeros();
495496

496497
gravity_mag_scgc = mu / pow(radius_scgc, 2);
497-
498-
//gravity_mag_scgc = sqrt(
499-
// gravity_vcgc[0] % gravity_vcgc[0] +
500-
// gravity_vcgc[1] % gravity_vcgc[1] +
501-
// gravity_vcgc[2] % gravity_vcgc[2]);
502498

503499
report.print(4, "Done gravity calculations for the dipole grid.");
504500

0 commit comments

Comments
 (0)