Release version 9.1.0 (#772)

Release v9.1.0

Author: wboereboom

.eslintrc.js

@@ -37,13 +37,21 @@ module.exports = {
   },
   extends: [
     "eslint:recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended"
   ],
   rules: {
     quotes: ["error", "double"],
     semi: ["error", "always"],
-    "@typescript-eslint/no-non-null-assertion": 0
+    "@typescript-eslint/no-non-null-assertion": 0,
+    "@typescript-eslint/ban-types": [
+      "error",
+      {
+        "extendDefaults": true,
+        "types": {
+          "{}": false
+        }
+      }
+    ]
   },
   overrides: [
     {

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@adyen/api-library",
-  "version": "9.0.0",
+  "version": "9.1.0",
   "description": "The Adyen API Library for NodeJS enables you to work with Adyen APIs.",
   "main": "lib/src/index.js",
   "types": "lib/src/index.d.ts",
@@ -35,25 +35,25 @@
   "author": "Ricardo Ambrogi",
   "license": "MIT",
   "devDependencies": {
-    "@types/jest": "26.0.24",
+    "@types/jest": "27.0.2",
     "@types/nock": "11.1.0",
-    "@typescript-eslint/eslint-plugin": "2.34.0",
-    "@typescript-eslint/parser": "2.34.0",
+    "@typescript-eslint/eslint-plugin": "4.31.2",
+    "@typescript-eslint/parser": "4.31.2",
     "acorn": "^8.0.1",
     "coveralls": "3.1.1",
     "dotenv": "^10.0.0",
-    "eslint": "6.8.0",
-    "jest": "25.5.4",
+    "eslint": "7.32.0",
+    "jest": "^27.0.6",
     "jest-ts-auto-mock": "^2.0.0",
     "kind-of": "^6.0.3",
     "minimist": ">=1.2.3",
-    "nock": "13.1.1",
-    "release-it": "14.10.1",
-    "ts-auto-mock": "^2.6.5",
-    "ts-jest": "25.5.1",
+    "nock": "13.1.3",
+    "release-it": "14.11.6",
+    "ts-auto-mock": "^3.3.5",
+    "ts-jest": "^27.0.4",
     "ts-loader": "8.0.10",
     "ttypescript": "^1.5.10",
-    "typescript": "3.9.10"
+    "typescript": "4.4.3"
   },
   "dependencies": {
     "https-proxy-agent": "5.0.0"

package.json

@@ -87,6 +87,15 @@ describe("Bin Lookup", function (): void {
     test.each([false, true])("should succeed on get cost estimate. isMock: %p", async function (isMock): Promise<void> {
         !isMock && nock.restore();
         const expected = {
+            cardBin:  {
+             bin: "",
+             fundsAvailability: "I",
+             issuingBank: "ADYEN TEST BANK",
+             issuingCountry: "NL",
+             paymentMethod: "visa",
+             payoutEligible: "Y",
+             summary: "",
+           },
             costEstimateAmount: {
                 currency: "EUR",
                 value: 10
@@ -117,4 +126,4 @@ describe("Bin Lookup", function (): void {
 
         expect(response).toEqual(expected);
     });
-});
+});

src/__tests__/binLookup.spec.ts

@@ -17,8 +17,7 @@
  * See the LICENSE file for more info.
  */
 
-/* eslint-disable @typescript-eslint/camelcase */
-
+/* eslint-disable @typescript-eslint/naming-convention */
 import checkServerIdentity from "../helpers/checkServerIdentity";
 import { PeerCertificate } from "tls";
 

src/__tests__/checkServerIdentity.spec.ts

@@ -184,7 +184,7 @@ describe("Checkout", (): void => {
 
     test.each([false, true])("should have valid payment methods, isMock: %p", async (isMock): Promise<void> => {
         !isMock && nock.restore();
-        const paymentMethodsRequest: PaymentMethodsRequest = {merchantAccount: "MagentoMerchantTest"};
+        const paymentMethodsRequest: PaymentMethodsRequest = {merchantAccount};
 
         scope.post("/paymentMethods")
             .reply(200, paymentMethodsSuccess);
@@ -271,7 +271,7 @@ describe("Checkout", (): void => {
         try {
             new Checkout(client);
             fail();
-        } catch (e) {
+        } catch (e: any) {
             expect(e.message).toEqual("Please provide your unique live url prefix on the setEnvironment() call on the Client or provide checkoutEndpoint in your config object.");
         }
     });

src/__tests__/checkout.spec.ts

@@ -32,7 +32,7 @@ const notificationRequestItem: { NotificationRequestItem: NotificationRequestIte
         merchantAccountCode: "merchantAccount",
         merchantReference: "reference",
         amount: {currency: "EUR", value: 1000},
-        eventCode: NotificationRequestItem.EventCodeEnum.REPORTAVAILABLE,
+        eventCode: NotificationRequestItem.EventCodeEnum.ReportAvailable,
         eventDate: "2019-09-21T11:45:24.637Z",
         paymentMethod: "VISA",
         reason: "reason",
@@ -92,7 +92,7 @@ describe("HMAC Validator", function (): void {
             merchantAccountCode: "merchantAccount",
             merchantReference: "reference",
             amount: {currency: "EUR", value: 1000},
-            eventCode: NotificationRequestItem.EventCodeEnum.REPORTAVAILABLE,
+            eventCode: NotificationRequestItem.EventCodeEnum.ReportAvailable,
             eventDate: "2019-09-21T11:45:24.637Z",
             paymentMethod: "VISA",
             reason: "reason",
@@ -101,7 +101,7 @@ describe("HMAC Validator", function (): void {
         };
         try {
         hmacValidator.validateHMAC(notificationRequestItemNoAdditionalData, key);
-        } catch(error) {
+        } catch(error: any) {
             expect(error.message).toEqual(`Missing ${ApiConstants.HMAC_SIGNATURE}`);
         }
     });

src/__tests__/hmacValidator.spec.ts

@@ -43,7 +43,7 @@ const getResponse = async ({apiKey , environment }: { apiKey: string; environmen
     try {
         await checkout.payments(createPaymentsCheckoutRequest());
         fail("request should fail");
-    } catch (e) {
+    } catch (e: any) {
         expect(e instanceof ErrorException).toBeTruthy();
         if (errorMessageEquals) expect(e.message).toEqual(errorMessageEquals);
         if (errorMessageContains) expect(e.message.toLowerCase()).toContain(errorMessageContains);

src/__tests__/httpClient.spec.ts

@@ -103,6 +103,7 @@ const createStandaloneCancelsResponse = (): StandalonePaymentCancelResource => {
 
 const createCapturesRequest = (): CreatePaymentCaptureRequest => {
     return {
+        reference: "reference",
         merchantAccount: process.env.ADYEN_MERCHANT!,
         amount: {
             currency: "EUR",
@@ -195,7 +196,7 @@ describe("Modification", (): void => {
         try {
             const result = await modification.amountUpdates(paymentPspReference, request);
             expect(result).toBeTruthy();
-        } catch (e) {
+        } catch (e: any) {
             fail(e.message);
         }
     });
@@ -209,7 +210,7 @@ describe("Modification", (): void => {
 
         try {
             await modification.amountUpdates(invalidPaymentPspReference, request);
-        } catch (e) {
+        } catch (e: any) {
             expect(e.statusCode).toBe(422);
             expect(e.message).toContain("Original pspReference required for this operation");
         }
@@ -223,7 +224,7 @@ describe("Modification", (): void => {
         try {
             const result = await modification.cancels(paymentPspReference, request);
             expect(result).toBeTruthy();
-        } catch (e) {
+        } catch (e: any) {
             fail(e.message);
         }
     });
@@ -236,7 +237,7 @@ describe("Modification", (): void => {
             .reply(422, invalidModificationResult);
         try {
             await modification.cancels(invalidPaymentPspReference, request);
-        } catch (e) {
+        } catch (e: any) {
             expect(e.statusCode).toBe(422);
             expect(e.message).toContain("Original pspReference required for this operation");
         }
@@ -250,7 +251,7 @@ describe("Modification", (): void => {
         try {
             const result = await modification.cancelsStandalone(request);
             expect(result).toBeTruthy();
-        } catch (e) {
+        } catch (e: any) {
             fail(e.message);
         }
     });
@@ -263,7 +264,7 @@ describe("Modification", (): void => {
         try {
             const result = await modification.captures(paymentPspReference, request);
             expect(result).toBeTruthy();
-        } catch (e) {
+        } catch (e: any) {
             fail(e.message);
         }
     });
@@ -276,7 +277,7 @@ describe("Modification", (): void => {
             .reply(422, invalidModificationResult);
         try {
             await modification.captures(invalidPaymentPspReference, request);
-        } catch (e) {
+        } catch (e: any) {
             expect(e.statusCode).toBe(422);
             expect(e.message).toContain("Original pspReference required for this operation");
         }
@@ -290,7 +291,7 @@ describe("Modification", (): void => {
         try {
             const result = await modification.refunds(paymentPspReference, request);
             expect(result).toBeTruthy();
-        } catch (e) {
+        } catch (e: any) {
             fail(e.message);
         }
     });
@@ -303,7 +304,7 @@ describe("Modification", (): void => {
             .reply(422, invalidModificationResult);
         try {
             await modification.refunds(invalidPaymentPspReference, request);
-        } catch (e) {
+        } catch (e: any) {
             expect(e.statusCode).toBe(422);
             expect(e.message).toContain("Original pspReference required for this operation");
         }
@@ -317,7 +318,7 @@ describe("Modification", (): void => {
         try {
             const result = await modification.reversals(paymentPspReference, request);
             expect(result).toBeTruthy();
-        } catch (e) {
+        } catch (e: any) {
             fail(e.message);
         }
     });
@@ -330,7 +331,7 @@ describe("Modification", (): void => {
             .reply(422, invalidModificationResult);
         try {
             await modification.reversals(invalidPaymentPspReference, request);
-        } catch (e) {
+        } catch (e: any) {
             expect(e.statusCode).toBe(422);
             expect(e.message).toContain("Original pspReference required for this operation");
         }

src/__tests__/modification.spec.ts

@@ -24,7 +24,6 @@ import refundTrue from "../__mocks__/notification/refundTrue.json";
 import refundFalse from "../__mocks__/notification/refundFalse.json";
 import NotificationRequest from "../notification/notificationRequest";
 import { Notification, NotificationRequestItem } from "../typings/notification/models";
-
 import NotificationEnum = NotificationRequestItem.EventCodeEnum;
 import SuccessEnum = NotificationRequestItem.SuccessEnum;
 
@@ -35,7 +34,7 @@ describe("Notification Test", function (): void {
 
         if (notificationRequest.notificationItems) {
             const notificationRequestItem: NotificationRequestItem = notificationRequest.notificationItems[0];
-            expect(NotificationEnum.AUTHORISATION).toEqual(notificationRequestItem.eventCode);
+            expect(NotificationEnum.Authorisation).toEqual(notificationRequestItem.eventCode);
             expect(notificationRequestItem.success === SuccessEnum.True).toBeTruthy();
             expect(notificationRequestItem.pspReference).toEqual("123456789");
         } else {
@@ -49,7 +48,7 @@ describe("Notification Test", function (): void {
 
         if (notificationRequest.notificationItems) {
             const notificationRequestItem = notificationRequest.notificationItems[0];
-            expect(NotificationEnum.CAPTURE).toEqual(notificationRequestItem.eventCode);
+            expect(NotificationEnum.Capture).toEqual(notificationRequestItem.eventCode);
             expect(notificationRequestItem.success === SuccessEnum.True).toBeTruthy();
             expect(notificationRequestItem.pspReference).toEqual("PSP_REFERENCE");
             expect(notificationRequestItem.originalReference).toEqual("ORIGINAL_PSP");
@@ -64,7 +63,7 @@ describe("Notification Test", function (): void {
 
         if (notificationRequest.notificationItems) {
             const notificationRequestItem = notificationRequest.notificationItems[0];
-            expect(NotificationEnum.CAPTURE).toEqual(notificationRequestItem.eventCode);
+            expect(NotificationEnum.Capture).toEqual(notificationRequestItem.eventCode);
             expect(notificationRequestItem.success === SuccessEnum.True).toBeFalsy();
             expect(notificationRequestItem.pspReference).toEqual("PSP_REFERENCE");
             expect(notificationRequestItem.originalReference).toEqual("ORIGINAL_PSP");
@@ -79,7 +78,7 @@ describe("Notification Test", function (): void {
 
         if (notificationRequest.notificationItems) {
             const notificationRequestItem = notificationRequest.notificationItems[0];
-            expect(NotificationEnum.REFUND).toEqual(notificationRequestItem.eventCode);
+            expect(NotificationEnum.Refund).toEqual(notificationRequestItem.eventCode);
             expect(notificationRequestItem.success === SuccessEnum.True).toBeTruthy();
             expect(notificationRequestItem.pspReference).toEqual("PSP_REFERENCE");
             expect(notificationRequestItem.originalReference).toEqual("ORIGINAL_PSP");
@@ -95,7 +94,7 @@ describe("Notification Test", function (): void {
 
         if (notificationRequest.notificationItems) {
             const notificationRequestItem = notificationRequest.notificationItems[0];
-            expect(NotificationEnum.REFUND).toEqual(notificationRequestItem.eventCode);
+            expect(NotificationEnum.Refund).toEqual(notificationRequestItem.eventCode);
             expect(notificationRequestItem.success === SuccessEnum.True).toBeFalsy();
             expect(notificationRequestItem.pspReference).toEqual("PSP_REFERENCE");
             expect(notificationRequestItem.originalReference).toEqual("ORIGINAL_PSP");