Create a new class for library constants (#1298)

Author: AlexandrosMor

src/client.ts

@@ -1,6 +1,5 @@
 import Config from "./config";
 import HttpURLConnectionClient from "./httpClient/httpURLConnectionClient";
-import { version } from "../package.json";
 import ClientInterface from "./httpClient/clientInterface";
 
 type ClientParametersOverload =
@@ -38,8 +37,6 @@ class Client {
     public static MARKETPAY_HOP_API_VERSION = "v6";
     public static MARKETPAY_NOTIFICATION_API_VERSION = "v5";
     public static MARKETPAY_NOTIFICATION_CONFIGURATION_API_VERSION = "v6";
-    public static LIB_NAME = "adyen-node-api-library";
-    public static LIB_VERSION: string = version;
     public static TERMINAL_API_ENDPOINT_TEST = "https://terminal-api-test.adyen.com";
     public static TERMINAL_API_ENDPOINT_LIVE = "https://terminal-api-live.adyen.com";
 

src/constants/libraryConstants.ts

@@ -0,0 +1,8 @@
+import { version } from "../../package.json";
+
+class LibraryConstants {
+    public static LIB_NAME = "adyen-node-api-library";
+    public static LIB_VERSION: string = version;
+}
+
+export default LibraryConstants;

src/httpClient/httpURLConnectionClient.ts

@@ -23,7 +23,7 @@ import { HttpsProxyAgent } from "https-proxy-agent";
 
 import * as fs from "fs";
 import { URL, URLSearchParams } from "url";
-import Client from "../client";
+import LibraryConstants from "../constants/libraryConstants";
 import Config from "../config";
 import HttpClientException from "./httpClientException";
 
@@ -111,9 +111,9 @@ class HttpURLConnectionClient implements ClientInterface {
         }
 
         requestOptions.headers[ApiConstants.ACCEPT_CHARSET] = HttpURLConnectionClient.CHARSET;
-        requestOptions.headers[ApiConstants.USER_AGENT] = `${applicationName} ${Client.LIB_NAME}/${Client.LIB_VERSION}`;
-        requestOptions.headers[ApiConstants.ADYEN_LIBRARY_NAME] = Client.LIB_NAME;
-        requestOptions.headers[ApiConstants.ADYEN_LIBRARY_VERSION] = Client.LIB_VERSION;
+        requestOptions.headers[ApiConstants.USER_AGENT] = `${applicationName} ${LibraryConstants.LIB_NAME}/${LibraryConstants.LIB_VERSION}`;
+        requestOptions.headers[ApiConstants.ADYEN_LIBRARY_NAME] = LibraryConstants.LIB_NAME;
+        requestOptions.headers[ApiConstants.ADYEN_LIBRARY_VERSION] = LibraryConstants.LIB_VERSION;
 
         return httpsRequest(requestOptions);
     }

src/typings/applicationInfo.ts

@@ -19,7 +19,7 @@
 
 // Generated using typescript-generator version 2.14.505 on 2019-06-11 10:28:22.
 
-import Client from "../client";
+import LibraryConstants from "../constants/libraryConstants";
 
 export class ApplicationInfo {
     adyenLibrary?: CommonField;
@@ -32,8 +32,8 @@ export class ApplicationInfo {
 
     constructor() {
         this.adyenLibrary = {
-            name: Client.LIB_NAME,
-            version: Client.LIB_VERSION,
+            name: LibraryConstants.LIB_NAME,
+            version: LibraryConstants.LIB_VERSION,
         };
     }
 }