Skip to content

Commit 4572fb4

Browse files
Disable Spawn on both Linux and Windows
Too many issues have been detected when using Spawn as the default API to laucnh external processes, so revert back to the old GPS.Kernel.Timeout API until we solve the identified issues. For eng/ide/eng/ide/gnatstudio#538
1 parent 25613e4 commit 4572fb4

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

kernel/src/gps-kernel-spawns.adb

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ with Commands;
3636

3737
package body GPS.Kernel.Spawns is
3838

39-
Me : constant Trace_Handle := Create ("GPS.KERNEL.SPAWN");
39+
Me : constant Trace_Handle := Create ("GPS.KERNEL.SPAWN", Off);
40+
-- Disable Spawn as the default API to launch external processes
41+
-- until we solve the remaining issues (#538 and #495).
42+
4043
Me_IO : constant Trace_Handle := Create
4144
("GPS.KERNEL.SPAWN_IO", Off);
4245

@@ -424,7 +427,7 @@ package body GPS.Kernel.Spawns is
424427
end if;
425428

426429
if Console /= null then
427-
Trace (Me, "Connect the command_handler to the console");
430+
Trace (Me_IO, "Connect the command_handler to the console");
428431
Console.Set_Command_Handler (Input_Handler'Access, Obj.all'Address);
429432

430433
Obj.Console := Console;
@@ -447,7 +450,7 @@ package body GPS.Kernel.Spawns is
447450
(Spawn.Process_Listeners.Process_Listener_Access (Obj));
448451

449452
Trace
450-
(Me, "Spawning " & GNATCOLL.Arg_Lists.To_Display_String (Arg_List));
453+
(Me_IO, "Spawning " & GNATCOLL.Arg_Lists.To_Display_String (Arg_List));
451454

452455
Obj.Ref; -- Keep command alive until process finishes
453456
Obj.Process.Start;

testsuite/tests/gs.507.no_silent_exit/test.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ def run_test():
1313
yield wait_tasks()
1414

1515
gps_assert(
16-
"process exited with status" in GPS.Console("Run: foo" + dot_exe).get_text(),
16+
"Could not locate executable" in GPS.Console().get_text(),
1717
True,
18-
"Missing message in the Messages view",
19-
)
18+
"We should have a message warning that the executable could "
19+
+ "not be found in the Messages view",
20+
)

0 commit comments

Comments
 (0)