Fix mypy issue

Author: liaiss

src/e3/anod/checkout.py

@@ -167,11 +167,14 @@ def update_external(
                         ],
                         output=PIPE,
                     ).out
-                    ignore_list = [
-                        f"/{f.strip().rstrip('/')}"
-                        for f in ignore_list_lines.splitlines()
-                    ]
-                    logger.debug("Ignore in external: %s", ignore_list)
+                    if ignore_list_lines is None:
+                        ignore_list = []
+                    else:
+                        ignore_list = [
+                            f"/{f.strip().rstrip('/')}"
+                            for f in ignore_list_lines.splitlines()
+                        ]
+                        logger.debug("Ignore in external: %s", ignore_list)
                 except Exception:  # defensive code
                     # don't crash on exception
                     pass
@@ -226,7 +229,12 @@ def update_git(
         # Do the remote addition manually as in that context we can ignore
         # safely any error returned by this command.
         try:
-            remote_list = g.git_cmd(["remote"], output=PIPE).out.splitlines()
+            output_str = g.git_cmd(["remote"], output=PIPE).out
+
+            remote_list = []
+            if output_str:
+                remote_list = output_str.splitlines()
+
             if remote_name not in remote_list:
                 g.git_cmd(["remote", "add", remote_name, url])
         except Exception:  # defensive code

src/e3/vcs/git.py

@@ -187,7 +187,7 @@ def describe(self, commit: str = HEAD) -> str:
         :raise: GitError
         """
         p = self.git_cmd(["describe", "--always", commit], output=PIPE)
-        return p.out.strip()
+        return p.out.strip()  # type: ignore
 
     def write_local_diff(self, stream: IO[str]) -> None:
         """Write local changes in the working tree in stream.
@@ -371,4 +371,4 @@ def rev_parse(self, refspec: str = HEAD) -> str:
         :raise: GitError
         """
         p = self.git_cmd(["rev-parse", "--revs-only", refspec], output=PIPE, error=PIPE)
-        return p.out.strip()
+        return p.out.strip()  # type: ignore

src/e3/vcs/svn.py

@@ -170,29 +170,30 @@ def svn_cmd(self, cmd: SVNCmd, **kwargs: Any) -> e3.os.process.Run:
             )
         return p
 
-    def get_info(self, item: str) -> str:
+    def get_info(self, item: str) -> Optional[str]:
         """Return a specific item shown by svn info.
 
         The --show-item option is only available from 1.9.
         :raise: SVNError
         """
         info = self.svn_cmd(["info"], output=PIPE).out
-        m = re.search(rf"^{item}: *(.*)\n", info, flags=re.M)
+        m = re.search(rf"^{item}: *(.*)\n", info, flags=re.M)  # type: ignore
         if m is None:
             logger.debug("svn info result:\n%s", info)
             raise SVNError(f"Cannot fetch item {item} from svn_info", origin="get_info")
-        return m.group(1).strip()
+
+        return m.group(1).strip()  # type: ignore
 
     @property
-    def url(self) -> str:
+    def url(self) -> Optional[str]:
         """Return the last URL used for the checkout.
 
         :raise: SVNError
         """
         return self.get_info("URL")
 
     @property
-    def current_revision(self) -> str:
+    def current_revision(self) -> Optional[str]:
         """Return the current revision.
 
         :raise: SVNError
@@ -229,7 +230,9 @@ def is_clean_svn_dir(dir_path: str) -> tuple[bool, bool]:
             """Return a tuple (True if dir is SVN directory, True if clean)."""
             if os.path.exists(os.path.join(dir_path, ".svn")):
                 try:
-                    status = self.svn_cmd(["status"], output=PIPE).out.strip()
+                    status = self.svn_cmd(
+                        ["status"], output=PIPE
+                    ).out.strip()  # type: ignore
                 except SVNError:  # defensive code
                     return False, False
                 if "warning: W" in status: