Skip to content

Commit dfe6d71

Browse files
committed
Set vscode task group on the resolved task
1 parent 3b9fde7 commit dfe6d71

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

integration/vscode/ada/src/taskProviders.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -453,10 +453,6 @@ export class SimpleTaskProvider implements vscode.TaskProvider {
453453
tDecl.problemMatchers
454454
);
455455

456-
if (tDecl.taskGroup) {
457-
task.group = tDecl.taskGroup;
458-
}
459-
460456
/**
461457
* Ideally we would have liked to provide unresolved tasks and let
462458
* resolving only happen in the resolveTask method, but that's not
@@ -466,6 +462,13 @@ export class SimpleTaskProvider implements vscode.TaskProvider {
466462
const resolvedTask = await this.resolveTask(task, token);
467463

468464
if (resolvedTask) {
465+
/**
466+
* Set other properties on the resolved task
467+
*/
468+
if (tDecl.taskGroup) {
469+
resolvedTask.group = tDecl.taskGroup;
470+
}
471+
469472
result.push(resolvedTask);
470473
} else {
471474
logger.error(`Failed to resolve task: ${JSON.stringify(task, undefined, 2)}`);

0 commit comments

Comments
 (0)