Merge branch 'topic/1298-external-tools-attributes-documentation' into 'master'

Add external tools attribute documentation

Closes #1298

See merge request eng/ide/ada_language_server!1504

Author: Philippe Gil

source/gpr/lsp-gpr_external_tools.adb

@@ -1,7 +1,7 @@
 ------------------------------------------------------------------------------
 --                         Language Server Protocol                         --
 --                                                                          --
---                     Copyright (C) 2023, AdaCore                          --
+--                     Copyright (C) 2023-2024, AdaCore                     --
 --                                                                          --
 -- This is free software;  you can redistribute it  and/or modify it  under --
 -- terms of the  GNU General Public License as published  by the Free Soft- --
@@ -184,7 +184,7 @@ package body LSP.GPR_External_Tools is
             Inherit_From_Extended => Inherit_From_Extended,
             Is_Set                => Is_Set);
       end if;
-      if Get_Attribute_Description (Name)'Length > 0
+      if Get_Attribute_Description (Name)'Length = 0
         and then Description'Length > 0
       then
          Set_Attribute_Description (Name, Description);

testsuite/gpr_lsp/hover/prj1.gpr

@@ -3,4 +3,7 @@ for Source_Dirs use ("src");
 package Compiler is
 for Switches ("Ada") use ();
 end Compiler;
+package IDE is
+for Artifacts_Dir use "";
+end IDE;
 end Prj1;

testsuite/gpr_lsp/hover/test.json

@@ -149,7 +149,7 @@
                   "uri":"$URI{prj1.gpr}",
                   "languageId":"Gpr",
                   "version":1,
-                  "text":"project Prj1 is\nfor Source_Dirs use (\"src\");\npackage Compiler is\nfor Switches (\"Ada\") use ();\nend Compiler;\nend Prj1;"
+                  "text":"project Prj1 is\nfor Source_Dirs use (\"src\");\npackage Compiler is\nfor Switches (\"Ada\") use ();\nend Compiler;\npackage IDE is\nfor Artifacts_Dir use \"\";\nend IDE;\nend Prj1;"
                }
             }
          },
@@ -330,6 +330,68 @@
          ]
       }
    },
+    {
+      "send":{
+         "request":{
+            "params":{
+               "position":{
+                  "line":5,
+                  "character":8
+               },
+               "textDocument":{
+                  "uri":"$URI{prj1.gpr}"
+               }
+            },
+            "jsonrpc":"2.0",
+            "id":7,
+            "method":"textDocument/hover"
+         },
+         "wait":[
+            {
+               "id":7,
+               "result":{
+                  "contents":[
+                     {
+                        "language": "plaintext",
+                        "value": "This package specifies the options used by 'gnatstudio' IDE."
+                     }
+                  ]
+               }
+            }
+         ]
+      }
+   },
+    {
+      "send":{
+         "request":{
+            "params":{
+               "position":{
+                  "line":6,
+                  "character":9
+               },
+               "textDocument":{
+                  "uri":"$URI{prj1.gpr}"
+               }
+            },
+            "jsonrpc":"2.0",
+            "id":8,
+            "method":"textDocument/hover"
+         },
+         "wait":[
+            {
+               "id":8,
+               "result":{
+                  "contents":[
+                     {
+                        "language": "plaintext",
+                        "value": "The directory in which the files generated by 'gnatstudio' for this project (cross-references database, locations etc.) are stored by default. Defaults to Object_Dir if not specified."
+                     }
+                  ]
+               }
+            }
+         ]
+      }
+   },
   {
       "send":{
          "request":{