Merge branch 'topic/tests_on_err' into 'master'

Enable test result uploading on errors.

See merge request eng/ide/ada_language_server!1142

Author: reznikmm

.gitlab-ci.yml

@@ -78,6 +78,7 @@ build_and_test:
     - if [ ! -z ${FAILED+x} ]; then echo "There was at least one testcase failure" && exit 1; fi
 
   artifacts:
+     when: always  #  Upload on errors too
      paths:
         - xunit_output.xml
      reports:

testsuite/drivers/basic.py

@@ -41,24 +41,12 @@ def run(self, previous_values, slot):
 
             if process.status:
                 # Nonzero status?
-                if process.status == 100:
-                    # This one is an xfail
-                    status = TestStatus.XFAIL
-                    break
-                else:
-                    # Unknown status!
-                    status = TestStatus.ERROR
-                    break
-            else:
-                # Status is 0...
-                if output:
-                    # ... and there is an output: that's a FAIL
-                    status = TestStatus.FAIL
-                    break
+                status = TestStatus.FAIL
+                break
 
         self.result.set_status(status)
         if output:
-            # If there's an output, capture it
-            self.result.out = output
+            # If there's an output, capture it as log
+            self.result.log = output
 
         self.push_result()