Merge remote branch 'origin/master' into edge

Author: automatic-merge

.github/ISSUE_TEMPLATE/bug-report.yaml

@@ -0,0 +1,67 @@
+name: Bug Report
+description: Create a bug report for the Ada Language Server. This can concern the LSP language server itself or
+  the VS Code extension on top of it.
+title: "[Bug]: "
+labels: ["bug"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ### Is there an existing issue for this?
+        Please search our [existing issues](https://github.com/AdaCore/ada_language_server/issues) to see if an issue already exists for the bug you encountered.
+
+        Please also don't hesitate to read our [documentation](https://github.com/AdaCore/ada_language_server) first.
+  - type: textarea
+    attributes:
+      label: Environment
+      description: |
+        Please provide the information for the following:
+          - OS and Version (provide this for both host and target if you are using a remote or containerized development environment)
+          - IDE Version (for example "VS Code 1.89.0" or "GNAT Studio 24.2")
+          - Ada & SPARK Extension Version (if using VS Code)
+      value: |
+        - OS and Version:
+        - IDE Version:
+        - Ada & SPARK Extension Version:
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Bug Summary and Reproducer
+      description: |
+        Please describe the feature (for example, completion) that is not working as expected.
+        Include information about the actual workspace project (for example, is the project an aggregate project, does it target native platforms or cross platforms etc.).
+      value: |
+        Bug Summary:
+
+        Steps to reproduce:
+
+        Expected behavior:
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Configuration and Logs
+      description: |
+        Please provide your VS Code workspace-specific configuration files and logs. Logs are in particular very useful to investigate bugs such as unexpected exceptions.
+          - `tasks.json` file (for VS Code task-related issues) or `launch.json` (for VS Code debug-related issues)
+          - Logs from running `Ada: Show extension output from the VS Code command palette
+          - Logs from the Ada Language Server in the  `$HOME/.als directory (`%USERPROFILE%/.als`` on Windows). More info about ALS logging can be found [here](https://github.com/AdaCore/ada_language_server/blob/master/doc/traces.md)
+      render: shell
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Other VS Code Extensions
+      description: If applicable, please list other extensions installed and if the issue persists after disabling other extensions.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Additional context
+      description: |
+        Here you can provide any other information that will give us more context
+        about the issue you are encountering (code sample, screenshots, screen recording of the issue,
+        call stacks, etc.)
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/enhancement-request.yaml

@@ -0,0 +1,17 @@
+name: Enhancement Request
+description: Suggest an idea for the Ada Language Server or the Ada & SPARK VS Code extension.
+title: "[Enhancement]: "
+labels: ["bug"]
+body:
+- type: markdown
+  attributes:
+    value: |
+      ### Is there an existing request for this enhancement?
+      Prior to creating a new feature request, please review our [existing enhancement requests](https://github.com/AdaCore/ada_language_server/labels/enhancement) to avoid duplicates.
+- type: textarea
+  attributes:
+    label: Enhancement Request
+    description: |
+      Describe the enhancement here.
+  validations:
+    required: true

README.md

@@ -255,7 +255,8 @@ formatting might no succeed on incomplete/illegal code.
   the project's search path, environment variables and the project's file
   name from the crate description.
 
-* **Project support**: there is no `Scenario` view: users should configure scenarios via the *ada.scenarioVariables* setting (see the settings list available [here](doc/refactoring_tools.md)). You can execute the *Ada: Reload project* command to reload your project after saving the new scenario values (use the *Ctrl+P* shortcut to invoke the **Command Palette**, allowing you to execute commands).
+* **Project support**: there is no `Scenario` view: users should configure scenarios via the *ada.scenarioVariables* setting (see the settings list available [here](doc/settings.md)). Saving the settings file after changing the values will automatically reload the project and update the
+predefined tasks to take into account the new scenario values.
 
   Source directories from imported projects should be added in a [workspace file](https://code.visualstudio.com/docs/editor/workspaces#_multiroot-workspaces). If you already have a workspace file, the extension will propose you to automatically add all the source directories coming from imported projects to your workspace automatically at startup.
 

integration/vscode/ada/package.json

@@ -359,10 +359,10 @@
                             "always"
                         ],
                         "enumDescriptions": [
-                            "Never list overridding and/or overridden suprograms.",
-                            "List overridding and/or overridden suprograms on dispatching calls and on abstract subprogram declarations.",
-                            "List overridding and/or overridden suprograms on declarations only.",
-                            "Always list overridding and/or overridden suprograms when possible."
+                            "Never list overriding and/or overridden subprograms.",
+                            "List overriding and/or overridden subprograms on dispatching calls and on abstract subprogram declarations.",
+                            "List overriding and/or overridden subprograms on declarations only.",
+                            "Always list overriding and/or overridden subprograms when possible."
                         ],
                         "default": "usage_and_abstract_only",
                         "description": "Controls the policy for displaying overriding and overridden subprograms on navigation requests such as 'Go To Definition' or 'Go To Implementations'."
@@ -401,7 +401,7 @@
             },
             {
                 "type": "object",
-                "title": "Miscelaneous",
+                "title": "Miscellaneous",
                 "properties": {
                     "ada.enableIndexing": {
                         "scope": "window",

integration/vscode/ada/src/commands.ts

@@ -38,7 +38,7 @@ export const CMD_BUILD_AND_DEBUG_MAIN = 'ada.buildAndDebugMain';
 export function registerCommands(context: vscode.ExtensionContext, clients: ExtensionState) {
     context.subscriptions.push(vscode.commands.registerCommand('ada.otherFile', otherFileHandler));
     context.subscriptions.push(
-        vscode.commands.registerCommand('ada.subprogramBox', addSupbrogramBoxCommand)
+        vscode.commands.registerCommand('ada.subprogramBox', addSubprogramBoxCommand)
     );
     context.subscriptions.push(
         vscode.commands.registerCommand('ada.showExtensionOutput', () => mainOutputChannel.show())
@@ -108,7 +108,7 @@ export function registerCommands(context: vscode.ExtensionContext, clients: Exte
  *
  *  procedure Foo is
  */
-async function addSupbrogramBoxCommand() {
+async function addSubprogramBoxCommand() {
     const activeEditor = vscode.window.activeTextEditor;
 
     await getEnclosingSymbol(activeEditor, [
@@ -202,7 +202,7 @@ interface TaskQuickPickItem extends vscode.QuickPickItem {
  * Propose to the User a list of build and run tasks, one for each main defined
  * in the project.
  *
- * Tasks defined explicitely in the workspace are identified as such in the
+ * Tasks defined explicitly in the workspace are identified as such in the
  * offered list and proposed first.
  *
  * The User can choose either to run the task as is, or click the secondary
@@ -519,7 +519,7 @@ async function buildAndDebugSpecifiedMain(main: vscode.Uri): Promise<void> {
          * The vscode API doesn't provide a way to list both automatically
          * provided and User-defined debug configurations. So instead, we
          * inspect the launch.json data if it exists, and the dynamic configs
-         * provided by the exctension. We look for a debug config that matches
+         * provided by the extension. We look for a debug config that matches
          * the given main URI.
          */
         // Create a launch config for this main to help with matching

integration/vscode/ada/src/debugConfigProvider.ts

@@ -171,7 +171,7 @@ export function getOrFindGdb(): string | undefined {
  * @param program - the executable to debug (optional)
  * @param main - the main source file to be displayed in the configuration label (optional)
  * @param name - the full name of the configuration (optional). If provided,
- * this name shortcircuits the automatic naming based on the 'main' or the
+ * this name short-circuits the automatic naming based on the 'main' or the
  * 'program' parameter.
  * @returns an AdaConfig
  */

integration/vscode/ada/src/extension.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-call */
 /*----------------------------------------------------------------------------
 --                         Language Server Protocol                         --
 --                                                                          --

integration/vscode/ada/src/gnattest.ts

@@ -15,7 +15,7 @@ export let testRunProfile: vscode.TestRunProfile;
 /**
  * Types definition for the Gnattest XML file structure. The types match the XML
  * generated by src/test-mapping.adb in the libadalang-tools repository. However
- * these types do not describe the entire XML strutcture. Only the elements used
+ * these types do not describe the entire XML structure. Only the elements used
  * are described.
  */
 export type Root = {
@@ -185,7 +185,7 @@ async function parseGnatTestXml(): Promise<Root> {
         // to obtain attributes.
         ignoreAttributes: false,
         // This prefix is used in the JS objects resulting from the parsing
-        // to differenciate attributes from child nodes.
+        // to differentiate attributes from child nodes.
         attributeNamePrefix: '@_',
         isArray: (_, jPath) => {
             return alwaysArray.indexOf(jPath) !== -1;

integration/vscode/ada/src/taskProviders.ts

@@ -996,7 +996,7 @@ function quoteCommandLine(cmd: string[]): vscode.ShellQuotedString[] {
 /**
  *
  * @param task - a task
- * @returns `true` if the task is defined explicitely in the workspace's tasks.json
+ * @returns `true` if the task is defined explicitly in the workspace's tasks.json
  */
 export function isFromWorkspace(task: vscode.Task): boolean {
     return task.source == 'Workspace';
@@ -1006,7 +1006,7 @@ export function isFromWorkspace(task: vscode.Task): boolean {
  *
  * @param task - a task
  * @returns the label typically generated for that task by vscode. For tasks not
- * defined explicitely in the workspace, this is `ada: <task name>`. For tasks
+ * defined explicitly in the workspace, this is `ada: <task name>`. For tasks
  * defined in the workspace simply return the name which should already include
  * the convention.
  */