fix: handle plugin loading failures gracefully

Prevent app from crashing when plugins fail to load and show user feedback
for each failed plugin while continuing to load other plugins.

Author: bajrangCoder

src/lib/loadPlugin.js

@@ -7,9 +7,14 @@ import actionStack from "./actionStack";
 export default async function loadPlugin(pluginId, justInstalled = false) {
 	const baseUrl = await helpers.toInternalUri(Url.join(PLUGIN_DIR, pluginId));
 	const cacheFile = Url.join(CACHE_STORAGE, pluginId);
-	const $script = <script src={Url.join(baseUrl, "main.js")}></script>;
-	document.head.append($script);
-	return new Promise((resolve) => {
+
+	return new Promise((resolve, reject) => {
+		const $script = <script src={Url.join(baseUrl, "main.js")}></script>;
+
+		$script.onerror = (error) => {
+			reject(new Error(`Failed to load script for plugin ${pluginId}`));
+		};
+
 		$script.onload = async () => {
 			const $page = Page("Plugin");
 			$page.show = () => {
@@ -25,19 +30,23 @@ export default async function loadPlugin(pluginId, justInstalled = false) {
 				actionStack.remove(pluginId);
 			};
 
-			if (!(await fsOperation(cacheFile).exists())) {
-				await fsOperation(CACHE_STORAGE).createFile(pluginId);
-			}
 			try {
+				if (!(await fsOperation(cacheFile).exists())) {
+					await fsOperation(CACHE_STORAGE).createFile(pluginId);
+				}
+
 				await acode.initPlugin(pluginId, baseUrl, $page, {
 					cacheFileUrl: await helpers.toInternalUri(cacheFile),
 					cacheFile: fsOperation(cacheFile),
 					firstInit: justInstalled,
 				});
+
+				resolve();
 			} catch (error) {
-				toast(`Error loading plugin ${pluginId}: ${error.message}`);
+				reject(error);
 			}
-			resolve();
 		};
+
+		document.head.append($script);
 	});
 }

src/lib/loadPlugins.js

@@ -4,15 +4,25 @@ import loadPlugin from "./loadPlugin";
 
 export default async function loadPlugins() {
 	const plugins = await fsOperation(PLUGIN_DIR).lsDir();
-	const promises = [];
+	const results = [];
 
 	if (plugins.length > 0) {
 		toast(strings["loading plugins"]);
 	}
 
-	plugins.forEach((pluginDir) => {
-		promises.push(loadPlugin(Url.basename(pluginDir.url)));
-	});
-	const results = await Promise.all(promises);
-	return results.length;
+	// Load plugins sequentially to better handle errors
+	for (const pluginDir of plugins) {
+		const pluginId = Url.basename(pluginDir.url);
+		try {
+			await loadPlugin(pluginId);
+			results.push(true);
+		} catch (error) {
+			window.log("error", `Failed to load plugin: ${pluginId}`);
+			window.log("error", error);
+			toast(`Failed to load plugin: ${pluginId}`);
+			results.push(false);
+		}
+	}
+
+	return results.filter(Boolean).length;
 }