Merge pull request #515 from Idclip/vfx_18_cmake_deprecations

CMake deprecation warnings for VFX 18 versions

Author: Idclip

CHANGES

@@ -32,6 +32,9 @@ Version 6.2.0 - In development
     - Added an OPENVDB_CODE_COVERAGE option to CMake.
     - CMake now automatically detects and configures the CXX11 ABI requirement
       for Houdini builds.
+    - CMake now issues deprecation warnings for 2017 VFX Reference Platform
+      version dependencies. In particular, C++11-only compilers are now
+      deprecated; OpenVDB 7.0 will require a C++14-compatible compiler.
 
     Bug fixes:
     - Replaced std::vector with std::deque as the underlying container

CMakeLists.txt

@@ -212,10 +212,25 @@ if(NOT DISABLE_DEPENDENCY_VERSION_CHECKS)
   set(MINIMUM_DOXYGEN_VERSION 1.8.8)
 endif()
 
+# VFX 18 deprecations to transition to MINIMUM_* variables in OpenVDB 7.0.0
+
+set(FUTURE_MINIMUM_CMAKE_VERSION 3.12)
+set(FUTURE_MINIMUM_GCC_VERSION 6.3.1)
+set(FUTURE_MINIMUM_ICC_VERSION 17)
+set(FUTURE_MINIMUM_MSVC_VERSION 19.10)
+set(FUTURE_MINIMUM_TBB_VERSION 2017.6)
+set(FUTURE_MINIMUM_NUMPY_VERSION 1.12.1)
+set(FUTURE_MINIMUM_HOUDINI_VERSION 17)
+
 #########################################################################
 
 # General CMake and CXX settings
 
+if(${CMAKE_VERSION} VERSION_LESS ${FUTURE_MINIMUM_CMAKE_VERSION})
+  message(DEPRECATION "Support for CMake versions < ${FUTURE_MINIMUM_CMAKE_VERSION} "
+    "is deprecated and will be removed.")
+endif()
+
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)
@@ -407,6 +422,10 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
       "\"${MINIMUM_GCC_VERSION}\". Found version \"${CMAKE_CXX_COMPILER_VERSION}\""
     )
   endif()
+  if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS FUTURE_MINIMUM_GCC_VERSION)
+    message(DEPRECATION "Support for GCC versions < ${FUTURE_MINIMUM_GCC_VERSION} "
+      "is deprecated and will be removed.")
+  endif()
   if(OPENVDB_CXX_STRICT)
     message(STATUS "Configuring GCC CXX warnings")
     set(HAS_AVAILABLE_WARNINGS TRUE)
@@ -432,7 +451,15 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
       "\"${MINIMUM_ICC_VERSION}\". Found version \"${CMAKE_CXX_COMPILER_VERSION}\""
     )
   endif()
+  if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS FUTURE_MINIMUM_ICC_VERSION)
+    message(DEPRECATION "Support for ICC versions < ${FUTURE_MINIMUM_ICC_VERSION} "
+      "is deprecated and will be removed.")
+  endif()
 elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS FUTURE_MINIMUM_MSVC_VERSION)
+    message(DEPRECATION "Support for MSVC versions < ${FUTURE_MINIMUM_MSVC_VERSION} "
+      "is deprecated and will be removed.")
+  endif()
   # Increase the number of sections that an object file can contain
   add_definitions("/bigobj")
 endif()

cmake/OpenVDBHoudiniSetup.cmake

@@ -181,6 +181,11 @@ if(Houdini_VERSION VERSION_LESS 17)
   endfunction()
 endif()
 
+if(Houdini_VERSION VERSION_LESS ${FUTURE_MINIMUM_HOUDINI_VERSION})
+  message(DEPRECATION "Support for Houdini versions < ${FUTURE_MINIMUM_HOUDINI_VERSION} "
+    "is deprecated and will be removed.")
+endif()
+
 # ------------------------------------------------------------------------
 #  Configure imported Houdini target
 # ------------------------------------------------------------------------

doc/changes.txt

@@ -44,6 +44,9 @@ Improvements:
 - Added an @c OPENVDB_CODE_COVERAGE option to CMake.
 - CMake now automatically detects and configures the CXX11 ABI requirement
   for Houdini builds.
+- CMake now issues deprecation warnings for 2017 VFX Reference Platform
+  version dependencies. In particular, C++11-only compilers are now
+  deprecated; OpenVDB 7.0 will require a C++14-compatible compiler.
 
 @par
 Bug fixes:

openvdb/CMakeLists.txt

@@ -78,6 +78,11 @@ else()
 endif()
 
 find_package(TBB ${MINIMUM_TBB_VERSION} REQUIRED COMPONENTS tbb)
+if(${Tbb_VERSION} VERSION_LESS FUTURE_MINIMUM_TBB_VERSION)
+  message(DEPRECATION "Support for TBB versions < ${FUTURE_MINIMUM_TBB_VERSION} "
+    "is deprecated and will be removed.")
+endif()
+
 find_package(ZLIB ${MINIMUM_ZLIB_VERSION} REQUIRED)
 
 if(USE_LOG4CPLUS)

openvdb/python/CMakeLists.txt

@@ -108,6 +108,12 @@ else()
   list(APPEND OPENVDB_PYTHON_DEPS Python::Python)
 endif()
 
+if(USE_NUMPY)
+  if(Python_NumPy_VERSION VERSION_LESS FUTURE_MINIMUM_NUMPY_VERSION)
+    message(DEPRECATION "Support for NumPy versions < ${FUTURE_MINIMUM_NUMPY_VERSION} "
+      "is deprecated and will be removed.")
+  endif()
+endif()
 
 # Boost python handling - try and find both python and pythonXx (version suffixed).
 # Prioritize the version suffixed library, failing if neither exist.