Move `scrolloff` outside of vim options

[cvigilv]

Hi! Awesome little plugin.

I was thinking on if you think its possible to move the scrolloff status outside of vim.o/vim.wo, this way one can implement a hot-reloading technique whenever on changes de scrolloff value.

Let me think what you think, I could attempt to implement it and submit a PR.

[cvigilv]

Also, if another plugin uses the scrolloff option for whatever reason, this plugin is automatically incompatible because it's constantly updating its value.

[Aasim-A]

Hi @cvigilv , The reason behind us changing the scrolloff value is that when it's higher than half the screen height, the plugin stops working because neovim overrides it's attempts to scroll past EOF.

If you find a solution to this then yes we can work independently of vim.o.scrolloff.

[Owen-Dechow]

@Aasim-A

If you find a solution to this then yes we can work independently of vim.o.scrolloff.

I was having a similar issue with the scrolloff being overwritten back to 0 in all cases (I think that had something to do with the order in which I was loading plugins, not your plugin), but I found a different approach that fixes this issue.

M.scroll = function()
    local cursor = vim.api.nvim_win_get_cursor(0)[1]

    if last_cursor then
        if cursor <= last_cursor then
            last_cursor = cursor
            return
        else
            last_cursor = cursor
        end
    end

    local top_line = vim.fn.line("w0")
    local height = vim.api.nvim_win_get_height(0)

    ::calculate_show::
    local target_show = cursor + vim.o.scrolloff
    local shown = top_line + height - 1
    if (target_show > shown) then
        vim.api.nvim_feedkeys(ctrl_e, "n", false)
        top_line = top_line + 1
        goto calculate_show
    end
end

I made a repo for this solution based on your plugin https://github.com/Owen-Dechow/scroll_eof_ctrl_e/. Hope this helps!

[Aasim-A]

I tried using a solution similar to this before, but when used in insert mode, it printed a lot of gibberish and was unusable.

Checkout #2

[Owen-Dechow]

I think I found a solution to that too. You were pushing ctrl e but if you pushing ctrl o ctrl e while in insert mode it executes ctrl e as if in normal mode. Ctrl e in insert mode has a different job than in normal mode.

[Aasim-A]

Interesting...

Ctrl e in insert mode has a different job than in normal mode.

Shouldn't vim.api.nvim_feedkeys always run the specified keys in normal mode?

[Owen-Dechow]

That was my impression also but as soon as I added ctrl o in insert mode it worked