-
Notifications
You must be signed in to change notification settings - Fork 82
Open
Labels
refactorClean up with no new functionalityClean up with no new functionality
Description
Describe your use case
The unit test for motorThermal
uses magic truth numbers to check that the test is passing. This should be changed to test specific portions of the code. Some ideas include:
- With the reaction wheel stopped, check heat dissipation when ambient and rw temperatures are different.
- With no friction, test heat generation from wheel power inefficiencies.
- With 100% efficiency, test heat generation solely from friction.
Describe alternatives solutions you've considered
The alternative would be to keep using these preset values.
Additional context
The use of magic numbers has many problems. See here for more information.
Metadata
Metadata
Assignees
Labels
refactorClean up with no new functionalityClean up with no new functionality
Type
Projects
Status
No status