Skip to content

Refactor motorThermal unit test #1068

@joaogvcarneiro

Description

@joaogvcarneiro

Describe your use case
The unit test for motorThermal uses magic truth numbers to check that the test is passing. This should be changed to test specific portions of the code. Some ideas include:

  • With the reaction wheel stopped, check heat dissipation when ambient and rw temperatures are different.
  • With no friction, test heat generation from wheel power inefficiencies.
  • With 100% efficiency, test heat generation solely from friction.

Describe alternatives solutions you've considered
The alternative would be to keep using these preset values.

Additional context
The use of magic numbers has many problems. See here for more information.

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorClean up with no new functionality

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions