Change temp to uint32_t in serial_format

grumpyengineer · web-flow · commit fbf4ac03d762 · 2023-02-21T19:51:10.000Z
Fix bug where calling set_format in MBED (which calls serial_format) causes the CTRL register to become corrupt due to saving its initial value to a uint8_t when the register is 32 bit wide
diff --git a/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1170/TARGET_EVK/serial_api.c b/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1170/TARGET_EVK/serial_api.c
@@ -91,7 +91,7 @@ void serial_baud(serial_t *obj, int baudrate)
 void serial_format(serial_t *obj, int data_bits, SerialParity parity, int stop_bits)
 {
     LPUART_Type *base = uart_addrs[obj->index];
-    uint8_t temp;
+    uint32_t temp;
     /* Set bit count and parity mode. */
     temp = base->CTRL & ~(LPUART_CTRL_PE_MASK | LPUART_CTRL_PT_MASK | LPUART_CTRL_M_MASK);
     if (parity != ParityNone) {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ void serial_baud(serial_t *obj, int baudrate)`
`91`	`91`	`void serial_format(serial_t *obj, int data_bits, SerialParity parity, int stop_bits)`
`92`	`92`	`{`
`93`	`93`	`LPUART_Type *base = uart_addrs[obj->index];`
`94`		`- uint8_t temp;`
	`94`	`+ uint32_t temp;`
`95`	`95`	`/* Set bit count and parity mode. */`
`96`	`96`	`temp = base->CTRL & ~(LPUART_CTRL_PE_MASK \| LPUART_CTRL_PT_MASK \| LPUART_CTRL_M_MASK);`
`97`	`97`	`if (parity != ParityNone) {`