Skip to content

Commit ae3c418

Browse files
diederikdehaasgregkh
authored andcommitted
PCI: dw-rockchip: Fix PHY function call sequence in rockchip_pcie_phy_deinit()
commit 286ed19 upstream. The documentation for the phy_power_off() function explicitly says that it must be called before phy_exit(). Hence, follow the same rule in rockchip_pcie_phy_deinit(). Fixes: 0e898eb ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver") Signed-off-by: Diederik de Haas <didi.debian@cknow.org> [mani: commit message change] Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Niklas Cassel <cassel@kernel.org> Reviewed-by: Dragan Simic <dsimic@manjaro.org> Acked-by: Shawn Lin <shawn.lin@rock-chips.com> Cc: stable@vger.kernel.org # v5.15+ Link: https://patch.msgid.link/20250417142138.1377451-1-didi.debian@cknow.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0835fbe commit ae3c418

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/dwc/pcie-dw-rockchip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,8 @@ static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip)
377377

378378
static void rockchip_pcie_phy_deinit(struct rockchip_pcie *rockchip)
379379
{
380-
phy_exit(rockchip->phy);
381380
phy_power_off(rockchip->phy);
381+
phy_exit(rockchip->phy);
382382
}
383383

384384
static const struct dw_pcie_ops dw_pcie_ops = {

0 commit comments

Comments
 (0)