Skip to content

Commit aaa25db

Browse files
dlechgregkh
authored andcommitted
iio: adc: ad7944: mask high bits on direct read
commit 7cdfbc0 upstream. Apply a mask to the raw value received over the SPI bus for unsigned direct reads. As we found recently, SPI controllers may not set unused bits to 0 when reading with bits_per_word != {8,16,32}. The ad7944 uses bits_per_word of 14 and 18, so we need to mask the value to be sure we returning the correct value to userspace during a direct read. Fixes: d1efcf8 ("iio: adc: ad7944: add driver for AD7944/AD7985/AD7986") Signed-off-by: David Lechner <dlechner@baylibre.com> Reviewed-by: Nuno Sá <nuno.sa@analog.com> Link: https://patch.msgid.link/20250505-iio-adc-ad7944-max-high-bits-on-direct-read-v1-1-b173facceefe@baylibre.com Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ea66a9e commit aaa25db

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/iio/adc/ad7944.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ static int ad7944_single_conversion(struct ad7944_adc *adc,
290290

291291
if (chan->scan_type.sign == 's')
292292
*val = sign_extend32(*val, chan->scan_type.realbits - 1);
293+
else
294+
*val &= GENMASK(chan->scan_type.realbits - 1, 0);
293295

294296
return IIO_VAL_INT;
295297
}

0 commit comments

Comments
 (0)