Skip to content

Fix assert ID issues found by ComplianceWarden implementation #312

@leo-barnes

Description

@leo-barnes

@DenizUgur noticed a bunch of issues with the assert IDs when adding them to ComplianceWarden.

gpac/ComplianceWarden#92 (comment)

  { "Section 4. Auxiliary Image Sequences\n"
    "The mono_chrome field in the Sequence Header OBU shall be set to 1.\n"
    "The color_range field in the Sequence Header OBU shall be set to 1.",
    "assert-1243aeeb,assert-12507edd",

Apparently the same assert IDs are duplicated between "Auxiliary Image Items" and "Auxiliary Image Sequences". We recently fixed something similar in some other place. Must have missed this case.

gpac/ComplianceWarden#92 (comment)
We should add the change here:

Additionally, if a file contains [=AV1 image sequences=] and the brand <code>[=avio=]</code> is used in the <code>[=FileTypeBox=]</code>, 
- <assert>the item constraints for this brand shall be met</assert> and <assert>at least one of the [=AV1 image sequences=] shall be made only of [=AV1 Samples=] marked as <code>'[=sync=]'</code></assert>. 
+ <assert>the item constraints for this brand shall be met and at least one of the [=AV1 image sequences=] shall be made only of [=AV1 Samples=] marked as <code>'[=sync=]'</code></assert>.
Conversely, <assert>if such a track exists and the constraints of the brand <code>[=avio=]</code> on [=AV1 image items=] are met, the brand should be used</assert>.

Metadata

Metadata

Assignees

Labels

blockingconformanceRelated to conformance suite. E.g. file updates, asserts, etc.spec

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions