Fix clippy (#3102)

* fix clippy

* libafl_frida/

* lol

* lol

---------

Co-authored-by: Toka <tokazerkje@outlook.com>

Author: rmalmain

Cargo.toml

@@ -173,6 +173,7 @@ similar_names = "allow"
 too_many_lines = "allow"
 comparison_chain = "allow"             # This lint makes **ZERO** sense
 unnecessary_debug_formatting = "allow" # :thumbsdown: :thumbsdown: :thumbsdown: :thumbsdown: :thumbsdown: :thumbsdown: 
+struct_field_names = "allow"           # ????
 
 [workspace.lints.rustdoc]
 # Deny

libafl/src/events/centralized.rs

@@ -405,8 +405,7 @@ where
                     ..
                 } => {
                     log::debug!(
-                        "Received {} from {client_id:?} ({client_config:?}, forward {forward_id:?})",
-                        event_name
+                        "Received {event_name} from {client_id:?} ({client_config:?}, forward {forward_id:?})"
                     );
 
                     log::debug!(

libafl/src/events/llmp/restarting.rs

@@ -561,7 +561,7 @@ where
         // Send this mesasge off and we are leaving.
         match send_tcp_msg(&mut stream, &msg) {
             Ok(()) => (),
-            Err(e) => log::error!("Failed to send tcp message {:#?}", e),
+            Err(e) => log::error!("Failed to send tcp message {e:#?}"),
         }
         log::debug!("Asking he broker to be disconnected");
         Ok(())

libafl/src/executors/forkserver.rs

@@ -1039,10 +1039,7 @@ where
             )));
         }
 
-        log::info!(
-            "All right - new fork server model version {} is up",
-            version
-        );
+        log::info!("All right - new fork server model version {version} is up");
 
         let status = forkserver.read_st().map_err(|err| {
             Error::illegal_state(format!("Reading from forkserver failed: {err:?}"))

libafl/src/executors/hooks/inprocess.rs

@@ -505,7 +505,7 @@ impl InProcessExecutorHandlerData {
 
                     if let Ok(bsod) = bsod {
                         if let Ok(r) = core::str::from_utf8(&bsod) {
-                            log::error!("{}", r);
+                            log::error!("{r}");
                         }
                     }
                 }

libafl/src/executors/hooks/unix.rs

@@ -247,7 +247,7 @@ pub mod unix_signal_handler {
                         let _ = writer.flush();
                     }
                     if let Ok(r) = core::str::from_utf8(&bsod) {
-                        log::error!("{}", r);
+                        log::error!("{r}");
                     }
                 }
 
@@ -287,7 +287,7 @@ pub mod unix_signal_handler {
                             let _ = writer.flush();
                         }
                         if let Ok(r) = core::str::from_utf8(&bsod) {
-                            log::error!("{}", r);
+                            log::error!("{r}");
                         }
                     }
                 }

libafl/src/mutators/token_mutations.rs

@@ -450,7 +450,7 @@ where
             let Some(meta) = state.metadata_map().get::<CmpValuesMetadata>() else {
                 return Ok(MutationResult::Skipped);
             };
-            log::trace!("meta: {:x?}", meta);
+            log::trace!("meta: {meta:x?}");
             meta.list.len()
         };
 
@@ -648,7 +648,7 @@ where
         let Some(meta) = state.metadata_map().get::<CmpValuesMetadata>() else {
             return Ok(MutationResult::Skipped);
         };
-        log::trace!("meta: {:x?}", meta);
+        log::trace!("meta: {meta:x?}");
 
         let Some(cmps_len) = NonZero::new(meta.list.len()) else {
             return Ok(MutationResult::Skipped);

libafl/src/stages/sync.rs

@@ -107,7 +107,7 @@ where
 
         let mut new_files = vec![];
         for dir in &self.sync_dirs {
-            log::debug!("Syncing from dir: {:?}", dir);
+            log::debug!("Syncing from dir: {dir:?}");
             let new_dir_files = find_new_files_rec(dir, &last)?;
             new_files.extend(new_dir_files);
         }
@@ -134,7 +134,7 @@ where
                 .unwrap()
                 .left_to_sync
                 .retain(|p| p != &path);
-            log::debug!("Syncing and evaluating {:?}", path);
+            log::debug!("Syncing and evaluating {path:?}");
             fuzzer.evaluate_input(state, executor, manager, &input)?;
         }
 

libafl/src/state/mod.rs

@@ -977,10 +977,7 @@ where
             self.reset_initial_files_state();
             self.canonicalize_input_dirs(in_dirs)?;
             if cores.ids.len() > corpus_size {
-                log::info!(
-                    "low intial corpus count ({}), no parallelism required.",
-                    corpus_size
-                );
+                log::info!("low intial corpus count ({corpus_size}), no parallelism required.");
             } else {
                 let core_index = cores
                     .ids

libafl_bolts/src/lib.rs

@@ -1106,7 +1106,7 @@ mod windows_logging {
         // Get the handle to standard output
         let h_stdout: HANDLE = get_stdout_handle();
 
-        if h_stdout == INVALID_HANDLE_VALUE {
+        if ptr::eq(h_stdout, INVALID_HANDLE_VALUE) {
             eprintln!("Failed to get standard output handle");
             return;
         }