Skip to content

Commit 2eab457

Browse files
authored
Merge pull request #342 from 4DModeller/338-shiny-app-in-mesh-building-tutorial-is-stuck
Shiny app in mesh building tutorial is stuck
2 parents c22ce63 + f6b8442 commit 2eab457

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

R/shiny_meshbuilder.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ meshbuilder_shiny <- function(
5555
stop("Cannot read latitude and longitude data from spatial data. Please ensure given names are correct.")
5656
}
5757

58-
default_max_edge_min <- 0.01
59-
default_max_edge_max <- 0.3
58+
default_max_edge_min <- 0.9
59+
default_max_edge_max <- 1.8
6060
default_offset_min <- 0.02
61-
default_offset_max <- 0.2
61+
default_offset_max <- 2
6262
default_cutoff <- 0.02
6363
# TODO - these defaults need changing?
6464
if (!is.null(max_edge)) {
@@ -234,7 +234,7 @@ meshbuilder_shiny <- function(
234234
spatial_data
235235
}
236236
})
237-
237+
238238
output$map <- leaflet::renderLeaflet({
239239
map_tiles <- c("OpenStreetMap", "Esri.WorldImagery", "OpenTopoMap")
240240
m <- mapview::mapview(mesh_spatial(), layer.name = "Mesh", col.regions = "#548C2F", map.types = map_tiles) + mapview::mapview(spatial(), layer.name = "Spatial")

vignettes/meshbuilder.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ sp_data <- fdmr::load_tutorial_data(dataset = "covid", filename = "spatial_data.
5454
head(sp_data)
5555
```
5656

57-
The `sp_data` object is a `SpatialPolygonsDataFrame` containing 6789 features for areas of England. This object contains all the contains all the values we
57+
The `sp_data` object is a `SpatialPolygonsDataFrame` containing 6789 features for areas of England. This object contains all the values we need to build a mesh.
5858
We can build a mesh by passing `sp_data` to the `mesh_builder` function.
5959

6060
```{r eval=FALSE}

0 commit comments

Comments
 (0)