Closes #16; Merge pull request #17 from ggplijter/fix-python3-venv-cmake

2b-t · web-flow · commit 1af8600feaf9 · 2025-02-08T21:46:28.000Z
Make CMake use venv Python version
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -53,7 +53,7 @@ install(TARGETS myactuator_rmd
 )
 
 if(PYTHON_BINDINGS)
-  find_package(Python REQUIRED COMPONENTS
+  find_package(Python3 REQUIRED COMPONENTS
     Development  
     Interpreter
   )
diff --git a/setup.py b/setup.py
@@ -30,7 +30,7 @@ def build_extension(self, ext: CMakeExtension) -> None:
 
         cmake_args = [
             f"-D CMAKE_LIBRARY_OUTPUT_DIRECTORY={extdir}{os.sep}",
-            f"-D PYTHON_EXECUTABLE={sys.executable}",
+            f"-D Python3_EXECUTABLE={sys.executable}",
             f"-D CMAKE_BUILD_TYPE={cfg}",
             f"-D PYTHON_BINDINGS=on"
         ]

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ install(TARGETS myactuator_rmd`
`53`	`53`	`)`
`54`	`54`
`55`	`55`	`if(PYTHON_BINDINGS)`
`56`		`- find_package(Python REQUIRED COMPONENTS`
	`56`	`+ find_package(Python3 REQUIRED COMPONENTS`
`57`	`57`	`Development`
`58`	`58`	`Interpreter`
`59`	`59`	`)`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ def build_extension(self, ext: CMakeExtension) -> None:`
`30`	`30`
`31`	`31`	`cmake_args = [`
`32`	`32`	`f"-D CMAKE_LIBRARY_OUTPUT_DIRECTORY={extdir}{os.sep}",`
`33`		`- f"-D PYTHON_EXECUTABLE={sys.executable}",`
	`33`	`+ f"-D Python3_EXECUTABLE={sys.executable}",`
`34`	`34`	`f"-D CMAKE_BUILD_TYPE={cfg}",`
`35`	`35`	`f"-D PYTHON_BINDINGS=on"`
`36`	`36`	`]`