Break up the path into bucket and relative path

Author: 1e100

WORKSPACE

@@ -4,8 +4,9 @@ load(":cloud_archive.bzl", "s3_archive")
 
 s3_archive(
     name = "archive",
+    bucket = "1e100-temp",
     build_file = "//:BUILD.archive",
+    file_path = "cloud_archive_test.zip",
     sha256 = "d0ff6239646b3a60e4d8926402281311e003ae03183b1ae24f2adba5d9289f04",
     strip_prefix = "cloud_archive_test",
-    url = "s3://depthwise-temp/cloud_archive_test.zip",
 )

cloud_archive.bzl

@@ -3,12 +3,15 @@
 
 
 def _s3_archive_impl(ctx):
-    url = ctx.attr.url
+    url = "s3://{}/{}".format(ctx.attr.bucket, ctx.attr.file_path)
     filename = ctx.path(url).basename
 
     # Download
     aws_cli_path = ctx.which("aws")
-    aws_cli_cmd = [aws_cli_path, "s3", "cp", url, "."]
+    profile_flags = []
+    if ctx.attr.aws_profile:
+        profile_flags = ["--profile", ctx.attr.aws_profile]
+    aws_cli_cmd = [aws_cli_path] + profile_flags + ["s3", "cp", url, "."]
     s3_result = ctx.execute(aws_cli_cmd)
     if s3_result.return_code != 0:
         fail("Failed to download {} from S3: {}".format(url, s3_result.stderr))
@@ -24,25 +27,29 @@ def _s3_archive_impl(ctx):
             url, ctx.attr.sha256, sha256))
 
     # Extract the downloaded archive.
-    print("Extracting {}".format(filename))
     ctx.extract(filename, stripPrefix=ctx.attr.strip_prefix)
 
     # Provide external BUILD file if requested.
     bash_path = ctx.os.environ.get("BAZEL_SH", "bash")
     if ctx.attr.build_file:
-      ctx.execute([bash_path, "-c", "rm -f BUILD BUILD.bazel"])
-      ctx.symlink(ctx.attr.build_file, "BUILD.bazel")
+        ctx.execute([bash_path, "-c", "rm -f BUILD BUILD.bazel"])
+        ctx.symlink(ctx.attr.build_file, "BUILD.bazel")
 
 
 s3_archive = repository_rule(
     implementation=_s3_archive_impl, attrs={
-        "url":
-        attr.string(mandatory=True, doc="S3 URL for the object"),
+        "bucket":
+        attr.string(mandatory=True, doc="S3 bucket name"),
+        "file_path":
+        attr.string(mandatory=True,
+                    doc="Relative path to the archive file within the bucket"),
+        "aws_profile":
+        attr.string(doc="AWS profile to use for authentication"),
         "sha256":
         attr.string(mandatory=True, doc="SHA256 checksum of the archive"),
         "build_file":
         attr.label(allow_single_file=True,
-                   doc="BUILD file for the unpacked archive."),
+                   doc="BUILD file for the unpacked archive"),
         "strip_prefix":
-        attr.string(doc="Prefix to strip when archive is unpacked."),
+        attr.string(doc="Prefix to strip when archive is unpacked"),
     })